Adding overflow menu to media player

third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 13 matching lines @@
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef MediaControlElements_h
 #define MediaControlElements_h
 
 #include "core/html/shadow/MediaControlElementTypes.h"
+#include <set>
 
 namespace blink {
 
 class TextTrack;
 
 // ----------------------------
 
 class MediaControlPanelElement final : public MediaControlDivElement {
 public:
     static MediaControlPanelElement* create(MediaControls&);
@@ skipping 43 matching lines @@
 
 // ----------------------------
 
 class MediaControlMuteButtonElement final : public MediaControlInputElement {
 public:
     static MediaControlMuteButtonElement* create(MediaControls&);
 
     bool willRespondToMouseClickEvents() override { return true; }
     void updateDisplayType() override;
 
+    String getText() override;
+
 private:
     explicit MediaControlMuteButtonElement(MediaControls&);
 
     void defaultEventHandler(Event*) override;
 };
 
 // ----------------------------
 
 class MediaControlPlayButtonElement final : public MediaControlInputElement {
 public:
@@ skipping 26 matching lines @@
 // ----------------------------
 
 class MediaControlToggleClosedCaptionsButtonElement final : public MediaControlInputElement {
 public:
     static MediaControlToggleClosedCaptionsButtonElement* create(MediaControls&);
 
     bool willRespondToMouseClickEvents() override { return true; }
 
     void updateDisplayType() override;
 
+    String getText() override;
+
 private:
     explicit MediaControlToggleClosedCaptionsButtonElement(MediaControls&);
 
     void defaultEventHandler(Event*) override;
 };
 
 // ----------------------------
 
 class MediaControlTextTrackListElement final : public MediaControlDivElement {
 public:
@@ skipping 13 matching lines @@
     // Returns the label for the track when a valid track is passed in and "Off" when the parameter is null.
     String getTextTrackLabel(TextTrack*);
     // Creates the track element in the list when a valid track is passed in and the "Off" item when the parameter is null.
     Element* createTextTrackListItem(TextTrack*);
 
     void showTextTrackAtIndex(unsigned);
     void disableShowingTextTracks();
 };
 
 // ----------------------------
+// Represents the overflow menu which is displayed when the width of the media
+// player is small enough that at least two buttons are no longer visible.
+class MediaControlOverflowMenu final : public MediaControlInputElement {

[liberato (no reviews please), 2016/08/24 16:44:22]

might want to include "Button" in the class name.  that's consistent with the
other button classes.  plus, in this case, it avoids confusion with the
MediaControlOverflowMenuListElement.  "OverflowMenu" sounds like it could be the
latter.

[kdsilva, 2016/08/26 18:11:03]

Done.

+public:
+    static MediaControlOverflowMenu* create(MediaControls&);
+
+    // The overflow button should respond to mouse clicks since we want a click
+    // to open up the menu.
+    bool willRespondToMouseClickEvents() override { return true; }
+
+private:
+    explicit MediaControlOverflowMenu(MediaControls&);
+
+    void defaultEventHandler(Event*) override;
+};
+
+// ----------------------------
+// Holds a list of elements within the overflow menu.
+class MediaControlOverflowMenuListElement final : public MediaControlDivElement {
+public:
+    static MediaControlOverflowMenuListElement* create(MediaControls&);
+
+    // A set of the MediaControlElementTypes that should appear in the
+    // overflow menu.
+    void setOverflowMenuControls(const std::set<MediaControlElementType>*);
+
+    // True to display overflow menu, false to hide.
+    void showOverflowMenu(bool);
+
+private:
+    explicit MediaControlOverflowMenuListElement(MediaControls&);
+
+    void defaultEventHandler(Event*) override;
+};
+
+// ----------------------------
 
 class MediaControlTimelineElement final : public MediaControlInputElement {
 public:
     static MediaControlTimelineElement* create(MediaControls&);
 
     bool willRespondToMouseClickEvents() override;
 
     // FIXME: An "earliest possible position" will be needed once that concept
     // is supported by HTMLMediaElement, see https://crbug.com/137275
     void setPosition(double);
     void setDuration(double);
-
 private:
     explicit MediaControlTimelineElement(MediaControls&);
 
     void defaultEventHandler(Event*) override;
     bool keepEventInNode(Event*) override;
 };
 
 // ----------------------------
 
 class MediaControlFullscreenButtonElement final : public MediaControlInputElement {
 public:
     static MediaControlFullscreenButtonElement* create(MediaControls&);
 
     bool willRespondToMouseClickEvents() override { return true; }
 
     void setIsFullscreen(bool);
 
+    String getText() override;
+
 private:
     explicit MediaControlFullscreenButtonElement(MediaControls&);
 
     void defaultEventHandler(Event*) override;
 };
 
 // ----------------------------
 
 class MediaControlCastButtonElement final : public MediaControlInputElement {
 public:
     static MediaControlCastButtonElement* create(MediaControls&, bool isOverlayButton);
 
     bool willRespondToMouseClickEvents() override { return true; }
 
     void setIsPlayingRemotely(bool);
 
+    String getText() override;
+
     // This will show a cast button if it is not covered by another element.
     // This MUST be called for cast button elements that are overlay elements.
     void tryShowOverlay();
 
 private:
     explicit MediaControlCastButtonElement(MediaControls&, bool isOverlayButton);
 
     const AtomicString& shadowPseudoId() const override;
     void defaultEventHandler(Event*) override;
     bool keepEventInNode(Event*) override;
@@ skipping 49 matching lines @@
 public:
     static MediaControlCurrentTimeDisplayElement* create(MediaControls&);
 
 private:
     explicit MediaControlCurrentTimeDisplayElement(MediaControls&);
 };
 
 } // namespace blink
 
 #endif // MediaControlElements_h