Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2242973002: Improvements for circluar blurs in GPU backend. (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improvements for circluar blurs in GPU backend. Use half plane approximation for small blur of a large circle. This reduces the number of textures used and also avoids numerical issues with large circle radii. Make GrCircleGradientEffect use fixed sized textures. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242973002 Committed: https://skia.googlesource.com/skia/+/af68fa11ed61d8a14d9ca15996e2da6ca06795eb

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : add back dump of solid radius #

Patch Set 4 : make param order consistent #

Patch Set 5 : update comment to reflect that optimization was implemented #

Patch Set 6 : Fix double to float conversion on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -96 lines) Patch
M src/effects/GrCircleBlurFragmentProcessor.h View 1 2 3 chunks +8 lines, -30 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 2 3 4 5 10 chunks +100 lines, -66 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
robertphillips
lgtm
4 years, 4 months ago (2016-08-15 22:06:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242973002/100001
4 years, 4 months ago (2016-08-16 14:49:17 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 16:25:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/af68fa11ed61d8a14d9ca15996e2da6ca06795eb

Powered by Google App Engine
This is Rietveld 408576698