Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2242893003: [LayoutNG] Switch NGConstraintSpace to NGLogicalSize (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Switch NGConstraintSpace to NGLogicalSize R=cbiesinger@chromium.org BUG=635619 Committed: https://crrev.com/0c76086a9624118b9e7cdd5ae03420abf529171d Cr-Commit-Position: refs/heads/master@{#411760}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 4 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 5 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
eae
4 years, 4 months ago (2016-08-12 17:27:20 UTC) #1
cbiesinger
lgtm https://codereview.chromium.org/2242893003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc (right): https://codereview.chromium.org/2242893003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc#newcode12 third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc:12: NGConstraintSpace::NGConstraintSpace(NGLogicalSize size) { size -> container_size? https://codereview.chromium.org/2242893003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h File ...
4 years, 4 months ago (2016-08-12 17:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242893003/20001
4 years, 4 months ago (2016-08-12 17:44:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/121786)
4 years, 4 months ago (2016-08-12 17:55:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242893003/20001
4 years, 4 months ago (2016-08-12 18:00:51 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/111688)
4 years, 4 months ago (2016-08-12 18:08:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242893003/20001
4 years, 4 months ago (2016-08-12 20:01:05 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 20:43:23 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 20:46:21 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c76086a9624118b9e7cdd5ae03420abf529171d
Cr-Commit-Position: refs/heads/master@{#411760}

Powered by Google App Engine
This is Rietveld 408576698