third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h - Issue 2242893003: [LayoutNG] Switch NGConstraintSpace to NGLogicalSize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h

Issue 2242893003: [LayoutNG] Switch NGConstraintSpace to NGLogicalSize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h

index 44e738344b50a1a96de808010a7872e998d6f619..c11e461350b434e9c9e0f20c396d82a3c63eb24c 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h

@@ -17,8 +17,8 @@ class CORE_EXPORT NGDerivedConstraintSpace final : public NGConstraintSpace {

public:

~NGDerivedConstraintSpace();

- LayoutUnit offset() const { return offset_; }

- LayoutUnit size() const { return size_; }

+ NGLogicalOffset Offset() const { return offset_; }

+ NGLogicalSize Size() const override { return size_; }

private:

NGDerivedConstraintSpace(const NGConstraintSpace* original,