|
[CacheStorage] Use QueryCache everywhere
This CL consolidates many code paths around the new QueryCache method. This CL:
1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option
As a consequence of using QueryCache everywhere, options are fully supported and tested.
For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is testing.
BUG= 631978, 426309, 499216, 482256, 520784
Committed: https://crrev.com/4694c8366a320f4fa85f4781f8e2fad565d62ef4
Cr-Commit-Position: refs/heads/master@{#413487}
Total comments: 26
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+772 lines, -265 lines) |
Patch |
|
M |
content/browser/cache_storage/cache_storage.h
|
View
|
1
2
3
4
5
6
7
8
9
|
4 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
7 chunks |
+8 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_cache.h
|
View
|
1
2
3
4
5
6
7
8
|
6 chunks |
+22 lines, -19 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_cache.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
11 chunks |
+109 lines, -146 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_cache_unittest.cc
|
View
|
1
2
3
4
5
6
|
10 chunks |
+174 lines, -24 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_dispatcher_host.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_manager.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_manager.cc
|
View
|
|
1 chunk |
+5 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/cache_storage/cache_storage_manager_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
6 chunks |
+165 lines, -25 lines |
0 comments
|
Download
|
|
M |
content/browser/service_worker/service_worker_browsertest.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/common/cache_storage/cache_storage_types.h
|
View
|
1
2
3
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-delete.js
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+31 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+56 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+50 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+53 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+75 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll-expected.txt
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-matchAll-expected.txt
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-matchAll-expected.txt
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/cachestorage/Cache.cpp
|
View
|
1
2
3
4
5
6
7
8
9
|
7 chunks |
+1 line, -16 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
|
View
|
1
2
3
4
5
6
7
8
9
|
3 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Depends on Patchset:
Total messages: 67 (57 generated)
|