Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: third_party/WebKit/Source/modules/cachestorage/Cache.cpp

Issue 2242883002: [CacheStorage] Use QueryCache everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from PS9 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/cachestorage/Cache.cpp
diff --git a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
index 260b762e49d0844bfed2ff48d4df3089534c921a..09d93f4c46ce78c5968110084097ebce60f0aebe 100644
--- a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
+++ b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
@@ -21,7 +21,6 @@
#include "modules/fetch/Response.h"
#include "platform/HTTPNames.h"
#include "platform/Histogram.h"
-#include "platform/RuntimeEnabledFeatures.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerCache.h"
#include <memory>
@@ -29,16 +28,6 @@ namespace blink {
namespace {
-void checkCacheQueryOptions(const CacheQueryOptions& options, ExecutionContext* context)
-{
- if (!RuntimeEnabledFeatures::cacheIgnoreSearchOptionEnabled() && options.ignoreSearch())
- context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Cache.match() does not support 'ignoreSearch' option yet. See http://crbug.com/520784"));
- if (options.ignoreMethod())
- context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Cache.match() does not support 'ignoreMethod' option yet. See http://crbug.com/482256"));
- if (options.ignoreVary())
- context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Cache.match() does not support 'ignoreVary' option yet. See http://crbug.com/499216"));
-}
-
// FIXME: Consider using CallbackPromiseAdapter.
class CacheMatchCallbacks : public WebServiceWorkerCache::CacheMatchCallbacks {
WTF_MAKE_NONCOPYABLE(CacheMatchCallbacks);
@@ -467,7 +456,7 @@ ScriptPromise Cache::keys(ScriptState* scriptState, const RequestInfo& request,
WebServiceWorkerCache::QueryParams Cache::toWebQueryParams(const CacheQueryOptions& options)
{
WebServiceWorkerCache::QueryParams webQueryParams;
- webQueryParams.ignoreSearch = options.ignoreSearch() && RuntimeEnabledFeatures::cacheIgnoreSearchOptionEnabled();
+ webQueryParams.ignoreSearch = options.ignoreSearch();
webQueryParams.ignoreMethod = options.ignoreMethod();
webQueryParams.ignoreVary = options.ignoreVary();
webQueryParams.cacheName = options.cacheName();
@@ -489,7 +478,6 @@ ScriptPromise Cache::matchImpl(ScriptState* scriptState, const Request* request,
{
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- checkCacheQueryOptions(options, scriptState->getExecutionContext());
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
@@ -513,7 +501,6 @@ ScriptPromise Cache::matchAllImpl(ScriptState* scriptState, const Request* reque
{
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- checkCacheQueryOptions(options, scriptState->getExecutionContext());
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
@@ -552,7 +539,6 @@ ScriptPromise Cache::deleteImpl(ScriptState* scriptState, const Request* request
WebVector<WebServiceWorkerCache::BatchOperation> batchOperations(size_t(1));
batchOperations[0].operationType = WebServiceWorkerCache::OperationTypeDelete;
request->populateWebServiceWorkerRequest(batchOperations[0].request);
- checkCacheQueryOptions(options, scriptState->getExecutionContext());
batchOperations[0].matchParams = toWebQueryParams(options);
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
@@ -627,7 +613,6 @@ ScriptPromise Cache::keysImpl(ScriptState* scriptState, const Request* request,
{
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- checkCacheQueryOptions(options, scriptState->getExecutionContext());
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();

Powered by Google App Engine
This is Rietveld 408576698