[CacheStorage] Use QueryCache everywhere

[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option

As a consequence of using QueryCache everywhere, options are fully supported and tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is testing.

BUG=631978, 426309, 499216, 482256, 520784
Committed: https://crrev.com/4694c8366a320f4fa85f4781f8e2fad565d62ef4
Cr-Commit-Position: refs/heads/master@{#413487}

[jkarlin, 2016-08-12 15:57:30]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 15:57:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-08-12 16:05:01]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache
3) Delete now uses QueryCache
4) Match now uses QueryCache (via MatchAll)

Because Delete and Match now use QueryCache, they also now support options.

BUG=631978
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previous was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978
==========

[jkarlin, 2016-08-12 16:05:19]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previous was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978
==========

[commit-bot: I haz the power, 2016-08-12 16:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:06:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jkarlin, 2016-08-12 16:08:13]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978 426309
==========

[jkarlin, 2016-08-12 16:08:23]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978 426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978,426309
==========

[jkarlin, 2016-08-12 16:17:01]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:17:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-08-12 17:05:21]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports options
6) Cache::Delete now supports options
7) CacheStorage::Match now supports options
8) CacheStorage::MatchAll now supports options

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::MatchAll now uses QueryCache
5) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

6) Cache::Match now supports options
7) Cache::Delete now supports options
8) CacheStorage::Match now supports options
9) CacheStorage::MatchAll now supports options

BUG=631978,426309
==========

[jkarlin, 2016-08-12 17:06:09]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::MatchAll now uses QueryCache
5) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

6) Cache::Match now supports options
7) Cache::Delete now supports options
8) CacheStorage::Match now supports options
9) CacheStorage::MatchAll now supports options

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::MatchAll now uses QueryCache
5) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

6) Cache::Match now supports options
7) Cache::Delete now supports options
8) Cache::MatchAll now supports options
9) CacheStorage::Match now supports options
10) CacheStorage::MatchAll now supports options

BUG=631978,426309
==========

[commit-bot: I haz the power, 2016-08-12 17:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:09:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jkarlin, 2016-08-12 17:52:35]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:13:15]

Dry run: Exceeded global retry quota

[jkarlin, 2016-08-15 14:33:30]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 14:33:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-08-15 15:06:13]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::MatchAll now uses QueryCache
5) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

6) Cache::Match now supports options
7) Cache::Delete now supports options
8) Cache::MatchAll now supports options
9) CacheStorage::Match now supports options
10) CacheStorage::MatchAll now supports options

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)


BUG=631978,426309
==========

[jkarlin, 2016-08-15 15:07:36]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)


BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) CacheStorage::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

[jkarlin, 2016-08-15 15:07:51]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere...

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) CacheStorage::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) CacheStorage::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

[commit-bot: I haz the power, 2016-08-15 15:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 15:57:40]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-08-15 17:12:29]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) CacheStorage::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

[jkarlin, 2016-08-15 18:55:01]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 18:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-08-15 18:56:41]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

[jkarlin, 2016-08-15 18:57:25]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking to QueryCache (previously was only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

[commit-bot: I haz the power, 2016-08-15 20:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:23:09]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-08-16 12:00:36]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309,499216,482256,520784
==========

[jkarlin, 2016-08-16 17:53:43]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested:

5) Cache::Match now supports all options (+ignore_method, ignore_search)
6) Cache::Delete now supports all options (+ignore_vary)
7) Cache::MatchAll now supports all options (+ignore_vary)
8) CacheStorage::Match now supports options (+ignore_method, ignore_search)
9) CacheStorage::MatchAll now supports options (+ignore_vary)
10) Cache::Keys now supports all options (+ignore_vary)

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

[jkarlin, 2016-08-16 17:57:52]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method.

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Cache::Delete now uses QueryCache
4) Cache::Match now uses QueryCache (via MatchAll)

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Match to use QueryCache (via MatchAll)
5) Adds unittests for all query params
6) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

[jkarlin, 2016-08-16 18:01:12]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Match to use QueryCache (via MatchAll)
5) Adds unittests for all query params
6) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

[jkarlin, 2016-08-16 18:01:26]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

[jkarlin, 2016-08-16 18:17:06]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784
==========

[jkarlin, 2016-08-16 18:24:26]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 18:24:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-08-16 18:28:32]

jkarlin@chromium.org changed reviewers:
+ cmumford@chromium.org, nhiroki@chromium.org

[jkarlin, 2016-08-16 18:28:33]

nhiroki@ PTAL at everything

cmumford@ FYI

[commit-bot: I haz the power, 2016-08-16 20:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:52:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2016-08-18 00:05:43]

LGTM

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage.cc (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage.cc:611: 
blank line

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage.h (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage.h:103: 
nit: blank line

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage.h:191: 
nit: blank line

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage_cache.cc (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_cache.cc:738: 
DCHECK_EQ(REQUESTS_AND_RESPONSES, query_cache_results->query_type);

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_cache.cc:789: if
(match_all_responses->at(0).blob_size > 0) {
OPTIONAL: For this case, QueryCache() doesn't have to scan the entire entries
and can early return when the first entry is found.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_cache.cc:797:
match_all_responses->at(0)),
Indent looks broken.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage_manager.h (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_manager.h:72: 
blank line

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_manager.h:77: 
ditto.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage_manager_unittest.cc (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_manager_unittest.cc:259: 
blank line

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
(right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js:111:

blank line

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
(right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js:134:

blank line

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/cachestorage/Cache.cpp:460:
webQueryParams.ignoreSearch = options.ignoreSearch() &&
RuntimeEnabledFeatures::cacheIgnoreSearchOptionEnabled();
Can you remove cacheIgnoreSearchOptionEnabled() and stop including
RuntimeEnabledFeatures.h?

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp (right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp:15: #include
"platform/RuntimeEnabledFeatures.h"
Can you remove this inclusion?

[jkarlin, 2016-08-18 14:04:02]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 14:04:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-08-18 14:05:08]

Patchset #10 (id:180001) has been deleted

[jkarlin, 2016-08-18 14:08:22]

jkarlin@chromium.org changed reviewers:
+ dglazkov@chromium.org

[jkarlin, 2016-08-18 14:08:24]

dglazkov@chromium.org: Please review changes in RuntimeEnabledFeatures.in,
thanks!

Some context: These CacheStorage query options have been in the IDL and have
printed console warnings when used. This CL makes sure that all cases of the
options work and removes the console warnings.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage.cc (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage.cc:611: 
On 2016/08/18 00:05:42, nhiroki wrote:
> blank line

Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage.h (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage.h:103: 
On 2016/08/18 00:05:42, nhiroki wrote:
> nit: blank line

Thanks, I would have thought git cl format would have caught that. Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage.h:191: 
On 2016/08/18 00:05:42, nhiroki wrote:
> nit: blank line

Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage_cache.cc (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_cache.cc:738: 
On 2016/08/18 00:05:42, nhiroki wrote:
> DCHECK_EQ(REQUESTS_AND_RESPONSES, query_cache_results->query_type);

Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_cache.cc:789: if
(match_all_responses->at(0).blob_size > 0) {
On 2016/08/18 00:05:42, nhiroki wrote:
> OPTIONAL: For this case, QueryCache() doesn't have to scan the entire entries
> and can early return when the first entry is found.

Ack. The reason I didn't add that optimization is that in the near future we're
going to support returning the entries in order of insertion. We won't know
insertion order until we read the entries.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_cache.cc:797:
match_all_responses->at(0)),
On 2016/08/18 00:05:42, nhiroki wrote:
> Indent looks broken.

Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage_manager.h (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_manager.h:72: 
On 2016/08/18 00:05:42, nhiroki wrote:
> blank line

Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_manager.h:77: 
On 2016/08/18 00:05:42, nhiroki wrote:
> ditto.

Done.

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
File content/browser/cache_storage/cache_storage_manager_unittest.cc (right):

https://codereview.chromium.org/2242883002/diff/160001/content/browser/cache_...
content/browser/cache_storage/cache_storage_manager_unittest.cc:259: 
On 2016/08/18 00:05:43, nhiroki wrote:
> blank line

Done.

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
(right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js:111:

On 2016/08/18 00:05:43, nhiroki wrote:
> blank line

Done.

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
(right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js:134:

On 2016/08/18 00:05:43, nhiroki wrote:
> blank line

Done.

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/cachestorage/Cache.cpp:460:
webQueryParams.ignoreSearch = options.ignoreSearch() &&
RuntimeEnabledFeatures::cacheIgnoreSearchOptionEnabled();
On 2016/08/18 00:05:43, nhiroki wrote:
> Can you remove cacheIgnoreSearchOptionEnabled() and stop including
> RuntimeEnabledFeatures.h?

Done.

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp (right):

https://codereview.chromium.org/2242883002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp:15: #include
"platform/RuntimeEnabledFeatures.h"
On 2016/08/18 00:05:43, nhiroki wrote:
> Can you remove this inclusion?

Done.

[jkarlin, 2016-08-19 11:20:31]

dglazkov@ PTAL, thanks!

[jkarlin, 2016-08-19 11:21:01]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 11:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 13:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 13:37:16]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-08-22 12:44:57]

jkarlin@chromium.org changed reviewers:
+ jochen@chromium.org

[jkarlin, 2016-08-22 12:47:43]

+jochen@ PTAL at runtimeenabledfeatures.in. 

The idl is unchanged, this CL just makes the (lgtm'd long ago Cache Storage API
launch) query options work consistently.

[jkarlin, 2016-08-22 12:51:48]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784
==========

[jochen (gone - plz use gerrit), 2016-08-22 15:51:36]

lgtm

[jkarlin, 2016-08-22 16:27:23]

Thanks!

[jkarlin, 2016-08-22 16:27:30]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-08-22 16:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2242883002/#ps200001
(title: "Address comments from PS9")

[commit-bot: I haz the power, 2016-08-22 16:28:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 18:49:11]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784
==========

[commit-bot: I haz the power, 2016-08-22 18:49:12]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-08-22 18:50:49]

Description was changed from

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784
==========

to

==========
[CacheStorage] Use QueryCache everywhere

This CL consolidates many code paths around the new QueryCache method. This CL:

1) Optimizes QueryCache in the case that only one lookup needs to be performed
2) Adds vary checking (and ignore_vary support) to QueryCache (previously was
only in match)
3) Changes Cache::Delete to use QueryCache
4) Changes Cache::Put to doom rather than call Delete before inserting
5) Changes Cache::Match to use QueryCache (via MatchAll)
6) Adds unittests for all query params
7) Adds layout tests for all query params
8) Removes the RuntimeEnabledFeature for the ignoreQuery option

As a consequence of using QueryCache everywhere, options are fully supported and
tested.

For reviewers: the good stuff is in cache_storage_cache.cc, most of the rest is
testing.

BUG=631978,426309,499216,482256,520784

Committed: https://crrev.com/4694c8366a320f4fa85f4781f8e2fad565d62ef4
Cr-Commit-Position: refs/heads/master@{#413487}
==========

[commit-bot: I haz the power, 2016-08-22 18:50:50]

Patchset 10 (id:??) landed as
https://crrev.com/4694c8366a320f4fa85f4781f8e2fad565d62ef4
Cr-Commit-Position: refs/heads/master@{#413487}