Settings Router Refactor: Allow no-op navigations.

Settings Router Refactor: Allow no-op navigations.

If the router swallows no-op navigations, repeated navigations from
settings-menu to the same section no longer scrolls the page.

Moreover - repeated navigations to the same anchor link are normally
are normally pushed to history, so coalescing these navigations into a
single history entry might be confusing.

BUG=636709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/289c535c036c6a3120b884a5f1e41cb89b18cf6e
Cr-Commit-Position: refs/heads/master@{#411782}

[tommycli, 2016-08-12 15:26:15]

Description was changed from

==========
Settings Router Refactor: Allow no-op navigations.

If the router swallows no-op navigations, repeated navigations from
settings-menu to the same section no longer scrolls the page.

Moreover - repeated navigations to the same anchor link are normally
are normally pushed to history, so coalescing these navigations into a
single history entry might be confusing.

BUG=636709
==========

to

==========
Settings Router Refactor: Allow no-op navigations.

If the router swallows no-op navigations, repeated navigations from
settings-menu to the same section no longer scrolls the page.

Moreover - repeated navigations to the same anchor link are normally
are normally pushed to history, so coalescing these navigations into a
single history entry might be confusing.

BUG=636709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-12 15:26:17]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 15:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-12 15:26:51]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-08-12 15:26:51]

dbeam: PTAL. Less problematic to allow no-op navigations than to swallow them.

Thanks

Tommy

[commit-bot: I haz the power, 2016-08-12 16:27:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:27:51]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-12 21:28:06]

yay <3 swapping one set of problems for another!

lgtm

[tommycli, 2016-08-12 21:30:49]

On 2016/08/12 21:28:06, Dan Beam wrote:
> yay <3 swapping one set of problems for another!
> 
> lgtm

yeah cest la vie

[tommycli, 2016-08-12 21:30:55]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-12 21:32:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:36:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 21:39:18]

Description was changed from

==========
Settings Router Refactor: Allow no-op navigations.

If the router swallows no-op navigations, repeated navigations from
settings-menu to the same section no longer scrolls the page.

Moreover - repeated navigations to the same anchor link are normally
are normally pushed to history, so coalescing these navigations into a
single history entry might be confusing.

BUG=636709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Allow no-op navigations.

If the router swallows no-op navigations, repeated navigations from
settings-menu to the same section no longer scrolls the page.

Moreover - repeated navigations to the same anchor link are normally
are normally pushed to history, so coalescing these navigations into a
single history entry might be confusing.

BUG=636709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/289c535c036c6a3120b884a5f1e41cb89b18cf6e
Cr-Commit-Position: refs/heads/master@{#411782}
==========

[commit-bot: I haz the power, 2016-08-12 21:39:19]

Patchset 1 (id:??) landed as
https://crrev.com/289c535c036c6a3120b884a5f1e41cb89b18cf6e
Cr-Commit-Position: refs/heads/master@{#411782}