chrome/browser/resources/settings/route.js - Issue 2242863002: Settings Router Refactor: Allow no-op navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2242863002: Settings Router Refactor: Allow no-op navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/route.js

diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js

index 981c574e4fb8fb26a7a6f376b2bbe27e4fefe1b7..9ce34b51fb10efe0d59d3b14eba6a8d15819c8d7 100644

--- a/chrome/browser/resources/settings/route.js

+++ b/chrome/browser/resources/settings/route.js

@@ -346,10 +346,6 @@ cr.define('settings', function() {

var navigateTo = function(route, opt_dynamicParameters) {

var params = opt_dynamicParameters || new URLSearchParams();

- if (assert(route) == currentRoute_ &&

- params.toString() == currentQueryParameters_.toString()) {

- return;

- }

var url = route.path;

if (opt_dynamicParameters) {

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »