chrome/browser/resources/settings/settings_main/settings_main.js - Issue 2242863002: Settings Router Refactor: Allow no-op navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2242863002: Settings Router Refactor: Allow no-op navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_main/settings_main.js

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js

index 408b68c55cad19cff860a9e067d7ee0d64d42732..caa06173ce140955ca8e0746aafa43f4008efeaa 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.js

+++ b/chrome/browser/resources/settings/settings_main/settings_main.js

@@ -204,7 +204,8 @@ Polymer({

* @private

ensureInDefaultSearchPage_: function() {

- settings.navigateTo(settings.Route.BASIC);

+ if (settings.getCurrentRoute() != settings.Route.BASIC)

+ settings.navigateTo(settings.Route.BASIC);

/**

« no previous file with comments | « chrome/browser/resources/settings/route.js ('k') | no next file » | no next file with comments »