Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2241643003: Fix a bug that some NativePage might overlap tabstrip on tablets (Closed)

Created:
4 years, 4 months ago by Ian Wen
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that some NativePage might overlap tabstrip on tablets After https://codereview.chromium.org/2239453002, the native page's layout params might be neglected by TabContentViewParent, when the latter tries to add the native view to the view hierarchy. This CL fixes this bug. BUG=637132 Committed: https://crrev.com/3ac48aa226fb60bbf15262a12d2b75b280c0598a Cr-Commit-Position: refs/heads/master@{#411531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL.
4 years, 4 months ago (2016-08-12 01:35:10 UTC) #2
gone
lgtm
4 years, 4 months ago (2016-08-12 01:39:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241643003/1
4 years, 4 months ago (2016-08-12 01:40:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 02:58:56 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 03:02:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ac48aa226fb60bbf15262a12d2b75b280c0598a
Cr-Commit-Position: refs/heads/master@{#411531}

Powered by Google App Engine
This is Rietveld 408576698