Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java

Issue 2241643003: Fix a bug that some NativePage might overlap tabstrip on tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java b/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
index 4ec11fe0de29e305b335a3acd0879680f7133aac..a98797e107c5a01067d83b1bfcfdb8ec547ef168 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
@@ -7,7 +7,7 @@ package org.chromium.chrome.browser;
import android.app.Activity;
import android.content.res.Resources;
import android.view.View;
-import android.view.ViewGroup.MarginLayoutParams;
+import android.widget.FrameLayout.LayoutParams;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
@@ -37,8 +37,8 @@ public abstract class BasicNativePage implements NativePage {
Resources res = mActivity.getResources();
- MarginLayoutParams layoutParams = new MarginLayoutParams(
- MarginLayoutParams.MATCH_PARENT, MarginLayoutParams.MATCH_PARENT);
+ LayoutParams layoutParams = new LayoutParams(LayoutParams.MATCH_PARENT,
+ LayoutParams.MATCH_PARENT);
layoutParams.setMargins(0,
res.getDimensionPixelSize(R.dimen.tab_strip_height)
+ res.getDimensionPixelSize(R.dimen.toolbar_height_no_shadow),
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698