Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 224163002: Move core features code to //extensions (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina, markusheintz_, miu+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move core features code to //extensions BUG=359618 TBR=kalman@chromium.org *extensions* TBR=hubbe@chromium.org tab_capture, cast_streaming TBR=scheib@chromium.org app_current_window_internal TBR=hongbo.min@intel.com system_cpu TBR=bauerb@chromium.org content_settings Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261579

Patch Set 1 #

Total comments: 3

Patch Set 2 : move tests #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -2562 lines) Patch
M apps/shell/common/shell_extensions_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_cpu/system_cpu_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/features/api_feature.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/common/extensions/features/api_feature.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/extensions/features/base_feature_provider.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/common/extensions/features/base_feature_provider.cc View 1 chunk +0 lines, -249 lines 0 comments Download
M chrome/common/extensions/features/base_feature_provider_unittest.cc View 1 1 chunk +0 lines, -199 lines 0 comments Download
M chrome/common/extensions/features/chrome_channel_feature_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/features/chrome_channel_feature_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/features/complex_feature.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/common/extensions/features/complex_feature.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M chrome/common/extensions/features/complex_feature_unittest.cc View 1 1 chunk +0 lines, -210 lines 0 comments Download
D chrome/common/extensions/features/manifest_feature.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/common/extensions/features/manifest_feature.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/common/extensions/features/permission_feature.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/common/extensions/features/permission_feature.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/common/extensions/features/simple_feature.h View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/common/extensions/features/simple_feature.cc View 1 chunk +0 lines, -482 lines 0 comments Download
D chrome/common/extensions/features/simple_feature_filter.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/common/extensions/features/simple_feature_filter.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/common/extensions/features/simple_feature_unittest.cc View 1 1 chunk +0 lines, -637 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 2 chunks +4 lines, -5 lines 3 comments Download
A + extensions/common/features/api_feature.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/features/api_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/features/base_feature_provider.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/features/base_feature_provider.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/common/features/base_feature_provider_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/common/features/complex_feature.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/features/complex_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/features/complex_feature_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/common/features/manifest_feature.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/features/manifest_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/features/permission_feature.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/features/permission_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/features/simple_feature.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/features/simple_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/features/simple_feature_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/features/simple_feature_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/common/features/simple_feature_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ken Rockot(use gerrit already)
Purely mechanical change except for //extensions/DEPS. James can you PTAL? Note that we still depend ...
6 years, 8 months ago (2014-04-03 16:58:17 UTC) #1
James Cook
https://codereview.chromium.org/224163002/diff/1/chrome/common/extensions/features/base_feature_provider_unittest.cc File chrome/common/extensions/features/base_feature_provider_unittest.cc (right): https://codereview.chromium.org/224163002/diff/1/chrome/common/extensions/features/base_feature_provider_unittest.cc#newcode1 chrome/common/extensions/features/base_feature_provider_unittest.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
6 years, 8 months ago (2014-04-03 17:52:58 UTC) #2
Ken Rockot(use gerrit already)
Ok, tests moved https://codereview.chromium.org/224163002/diff/1/chrome/common/extensions/features/base_feature_provider_unittest.cc File chrome/common/extensions/features/base_feature_provider_unittest.cc (right): https://codereview.chromium.org/224163002/diff/1/chrome/common/extensions/features/base_feature_provider_unittest.cc#newcode1 chrome/common/extensions/features/base_feature_provider_unittest.cc:1: // Copyright (c) 2012 The Chromium ...
6 years, 8 months ago (2014-04-03 20:08:37 UTC) #3
James Cook
LGTM. Nice patch. https://codereview.chromium.org/224163002/diff/20001/extensions/DEPS File extensions/DEPS (left): https://codereview.chromium.org/224163002/diff/20001/extensions/DEPS#oldcode44 extensions/DEPS:44: "+chrome/common/extensions/permissions/socket_permission.h", On 2014/04/03 20:08:38, Ken Rockot ...
6 years, 8 months ago (2014-04-03 20:28:24 UTC) #4
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 20:43:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/224163002/20001
6 years, 8 months ago (2014-04-03 20:43:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 21:31:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 21:31:18 UTC) #8
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-03 21:42:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/224163002/20001
6 years, 8 months ago (2014-04-03 21:42:17 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 23:45:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 261579

Powered by Google App Engine
This is Rietveld 408576698