Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: extensions/common/features/base_feature_provider.h

Issue 224163002: Move core features code to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_ 5 #ifndef EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
6 #define CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_ 6 #define EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/memory/linked_ptr.h" 12 #include "base/memory/linked_ptr.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/common/extensions/features/simple_feature.h"
15 #include "extensions/common/features/feature_provider.h" 14 #include "extensions/common/features/feature_provider.h"
15 #include "extensions/common/features/simple_feature.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 // Reads Features out of a simple JSON file description. 19 // Reads Features out of a simple JSON file description.
20 class BaseFeatureProvider : public FeatureProvider { 20 class BaseFeatureProvider : public FeatureProvider {
21 public: 21 public:
22 typedef SimpleFeature*(*FeatureFactory)(); 22 typedef SimpleFeature*(*FeatureFactory)();
23 23
24 // Creates a new BaseFeatureProvider. Pass null to |factory| to have the 24 // Creates a new BaseFeatureProvider. Pass null to |factory| to have the
25 // provider create plain old Feature instances. 25 // provider create plain old Feature instances.
(...skipping 17 matching lines...) Expand all
43 FeatureMap features_; 43 FeatureMap features_;
44 44
45 // Populated on first use. 45 // Populated on first use.
46 mutable std::vector<std::string> feature_names_; 46 mutable std::vector<std::string> feature_names_;
47 47
48 FeatureFactory factory_; 48 FeatureFactory factory_;
49 }; 49 };
50 50
51 } // namespace extensions 51 } // namespace extensions
52 52
53 #endif // CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_ 53 #endif // EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698