Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/common/extensions/features/complex_feature_unittest.cc

Issue 224163002: Move core features code to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/complex_feature_unittest.cc
diff --git a/chrome/common/extensions/features/complex_feature_unittest.cc b/chrome/common/extensions/features/complex_feature_unittest.cc
deleted file mode 100644
index 076de5326defe4c878ae41781b97764401cc0507..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/features/complex_feature_unittest.cc
+++ /dev/null
@@ -1,210 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/features/complex_feature.h"
-
-#include "chrome/common/extensions/features/api_feature.h"
-#include "chrome/common/extensions/features/chrome_channel_feature_filter.h"
-#include "chrome/common/extensions/features/feature_channel.h"
-#include "chrome/common/extensions/features/simple_feature.h"
-#include "extensions/common/test_util.h"
-#include "extensions/common/value_builder.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using chrome::VersionInfo;
-using extensions::APIFeature;
-using extensions::ComplexFeature;
-using extensions::DictionaryBuilder;
-using extensions::Feature;
-using extensions::ListBuilder;
-using extensions::Manifest;
-using extensions::ScopedCurrentChannel;
-using extensions::SimpleFeature;
-using extensions::test_util::ParseJsonDictionaryWithSingleQuotes;
-
-namespace {
-
-class ExtensionComplexFeatureTest : public testing::Test {
- protected:
- ExtensionComplexFeatureTest()
- : current_channel_(VersionInfo::CHANNEL_UNKNOWN) {}
- virtual ~ExtensionComplexFeatureTest() {}
-
- SimpleFeature* CreateFeature() {
- SimpleFeature* feature = new SimpleFeature();
- feature->AddFilter(scoped_ptr<extensions::SimpleFeatureFilter>(
- new extensions::ChromeChannelFeatureFilter(feature)));
- return feature;
- }
-
- private:
- ScopedCurrentChannel current_channel_;
-};
-
-TEST_F(ExtensionComplexFeatureTest, MultipleRulesWhitelist) {
- const std::string kIdFoo("fooabbbbccccddddeeeeffffgggghhhh");
- const std::string kIdBar("barabbbbccccddddeeeeffffgggghhhh");
- scoped_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
-
- // Rule: "extension", whitelist "foo".
- scoped_ptr<SimpleFeature> simple_feature(CreateFeature());
- scoped_ptr<base::DictionaryValue> rule(
- DictionaryBuilder()
- .Set("whitelist", ListBuilder().Append(kIdFoo))
- .Set("extension_types", ListBuilder()
- .Append("extension")).Build());
- simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
-
- // Rule: "legacy_packaged_app", whitelist "bar".
- simple_feature.reset(CreateFeature());
- rule = DictionaryBuilder()
- .Set("whitelist", ListBuilder().Append(kIdBar))
- .Set("extension_types", ListBuilder()
- .Append("legacy_packaged_app")).Build();
- simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
-
- scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
-
- // Test match 1st rule.
- EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- kIdFoo,
- Manifest::TYPE_EXTENSION,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
-
- // Test match 2nd rule.
- EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- kIdBar,
- Manifest::TYPE_LEGACY_PACKAGED_APP,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
-
- // Test whitelist with wrong extension type.
- EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- kIdBar,
- Manifest::TYPE_EXTENSION,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
- EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(kIdFoo,
- Manifest::TYPE_LEGACY_PACKAGED_APP,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
-}
-
-TEST_F(ExtensionComplexFeatureTest, MultipleRulesChannels) {
- scoped_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
-
- // Rule: "extension", channel trunk.
- scoped_ptr<SimpleFeature> simple_feature(CreateFeature());
- scoped_ptr<base::DictionaryValue> rule(
- DictionaryBuilder()
- .Set("channel", "trunk")
- .Set("extension_types", ListBuilder().Append("extension")).Build());
- simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
-
- // Rule: "legacy_packaged_app", channel stable.
- simple_feature.reset(CreateFeature());
- rule = DictionaryBuilder()
- .Set("channel", "stable")
- .Set("extension_types", ListBuilder()
- .Append("legacy_packaged_app")).Build();
- simple_feature->Parse(rule.get());
- features->push_back(simple_feature.release());
-
- scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
-
- // Test match 1st rule.
- {
- ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_UNKNOWN);
- EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "1",
- Manifest::TYPE_EXTENSION,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
- }
-
- // Test match 2nd rule.
- {
- ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_BETA);
- EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "2",
- Manifest::TYPE_LEGACY_PACKAGED_APP,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
- }
-
- // Test feature not available to extensions above channel unknown.
- {
- ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_BETA);
- EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "1",
- Manifest::TYPE_EXTENSION,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM,
- Feature::GetCurrentPlatform()).result());
- }
-}
-
-// Tests a complex feature with blocked_in_service_worker returns true for
-// IsBlockedInServiceWorker().
-TEST_F(ExtensionComplexFeatureTest, BlockedInServiceWorker) {
- scoped_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
-
- // Two feature rules, both with blocked_in_service_worker: true.
- scoped_ptr<SimpleFeature> api_feature(new APIFeature());
- api_feature->Parse(ParseJsonDictionaryWithSingleQuotes(
- "{"
- " 'channel': 'trunk',"
- " 'blocked_in_service_worker': true"
- "}").get());
- features->push_back(api_feature.release());
-
- api_feature.reset(new APIFeature());
- api_feature->Parse(ParseJsonDictionaryWithSingleQuotes(
- "{"
- " 'channel': 'stable',"
- " 'blocked_in_service_worker': true"
- "}").get());
- features->push_back(api_feature.release());
-
- EXPECT_TRUE(ComplexFeature(features.Pass()).IsBlockedInServiceWorker());
-}
-
-// Tests a complex feature without blocked_in_service_worker returns false for
-// IsBlockedInServiceWorker().
-TEST_F(ExtensionComplexFeatureTest, NotBlockedInServiceWorker) {
- scoped_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
-
- // Two feature rules without blocked_in_service_worker.
- scoped_ptr<SimpleFeature> api_feature(new APIFeature());
- api_feature->Parse(ParseJsonDictionaryWithSingleQuotes(
- "{"
- " 'channel': 'trunk'"
- "}").get());
- features->push_back(api_feature.release());
-
- api_feature.reset(new APIFeature());
- api_feature->Parse(ParseJsonDictionaryWithSingleQuotes(
- "{"
- " 'channel': 'stable'"
- "}").get());
- features->push_back(api_feature.release());
-
- EXPECT_FALSE(ComplexFeature(features.Pass()).IsBlockedInServiceWorker());
-}
-
-} // namespace

Powered by Google App Engine
This is Rietveld 408576698