Use StringView for String::replace.

Use StringView for String::replace.

This avoids allocating temporary strings when calling ::replace("a", "b").

Note that unlike other String simplifications done recently we don't add this
API to AtomicString since doing replace() calls on an AtomicString and
allocating more AtomicStrings isn't something we really expect people to do.

BUG=615174
Committed: https://crrev.com/f4231901c30a54d3a94de3c7be22ffab13011032
Cr-Commit-Position: refs/heads/master@{#411846}

[esprehn, 2016-08-12 17:37:29]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:50:33]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[esprehn, 2016-08-12 17:52:22]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2016-08-12 17:55:41]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:56:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:07:03]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-08-12 18:33:16]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 18:33:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:07:30]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-08-12 22:17:12]

Description was changed from

==========
Use StringView for String::replace.


BUG=
==========

to

==========
Use StringView for String::replace.

This avoids allocating temporary strings when calling ::replace("a", "b").

BUG=615174
==========

[esprehn, 2016-08-12 22:17:32]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org

[esprehn, 2016-08-12 22:29:01]

Description was changed from

==========
Use StringView for String::replace.

This avoids allocating temporary strings when calling ::replace("a", "b").

BUG=615174
==========

to

==========
Use StringView for String::replace.

This avoids allocating temporary strings when calling ::replace("a", "b").

Note that unlike other String simplifications done recently we don't add this
API to AtomicString since doing replace() calls on an AtomicString and
allocating more AtomicStrings isn't something we really expect people to do.

BUG=615174
==========

[haraken, 2016-08-13 01:26:00]

LGTM

[esprehn, 2016-08-13 01:27:12]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-13 01:27:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 01:32:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-13 01:38:53]

Description was changed from

==========
Use StringView for String::replace.

This avoids allocating temporary strings when calling ::replace("a", "b").

Note that unlike other String simplifications done recently we don't add this
API to AtomicString since doing replace() calls on an AtomicString and
allocating more AtomicStrings isn't something we really expect people to do.

BUG=615174
==========

to

==========
Use StringView for String::replace.

This avoids allocating temporary strings when calling ::replace("a", "b").

Note that unlike other String simplifications done recently we don't add this
API to AtomicString since doing replace() calls on an AtomicString and
allocating more AtomicStrings isn't something we really expect people to do.

BUG=615174

Committed: https://crrev.com/f4231901c30a54d3a94de3c7be22ffab13011032
Cr-Commit-Position: refs/heads/master@{#411846}
==========

[commit-bot: I haz the power, 2016-08-13 01:38:54]

Patchset 3 (id:??) landed as
https://crrev.com/f4231901c30a54d3a94de3c7be22ffab13011032
Cr-Commit-Position: refs/heads/master@{#411846}