Use StringView for String::replace.

third_party/WebKit/Source/wtf/text/StringImpl.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 375 matching lines @@
     bool startsWith(UChar) const;
     bool startsWith(const StringView&) const;
     bool startsWithIgnoringCase(const StringView&) const;
     bool startsWithIgnoringASCIICase(const StringView&) const;
 
     bool endsWith(UChar) const;
     bool endsWith(const StringView&) const;
     bool endsWithIgnoringCase(const StringView&) const;
     bool endsWithIgnoringASCIICase(const StringView&) const;
 
-    PassRefPtr<StringImpl> replace(UChar, UChar);
-    PassRefPtr<StringImpl> replace(UChar, StringImpl*);
-    ALWAYS_INLINE PassRefPtr<StringImpl> replace(UChar pattern, const char* replacement, unsigned replacementLength) { return replace(pattern, reinterpret_cast<const LChar*>(replacement), replacementLength); }
-    PassRefPtr<StringImpl> replace(UChar, const LChar*, unsigned replacementLength);
-    PassRefPtr<StringImpl> replace(UChar, const UChar*, unsigned replacementLength);
-    PassRefPtr<StringImpl> replace(StringImpl*, StringImpl*);
-    PassRefPtr<StringImpl> replace(unsigned index, unsigned len, StringImpl*);
+    // Replace parts of the string.
+    PassRefPtr<StringImpl> replace(UChar pattern, UChar replacement);
+    PassRefPtr<StringImpl> replace(UChar pattern, const StringView& replacement);
+    PassRefPtr<StringImpl> replace(const StringView& pattern, const StringView& replacement);
+    PassRefPtr<StringImpl> replace(unsigned index, unsigned lengthToReplace, const StringView& replacement);
+
     PassRefPtr<StringImpl> upconvertedString();
 
 #if OS(MACOSX)
     RetainPtr<CFStringRef> createCFString();
 #endif
 #ifdef __OBJC__
     operator NSString*();
 #endif
 
 #ifdef STRING_STATS
     ALWAYS_INLINE static StringStats& stringStats() { return m_stringStats; }
 #endif
     static const UChar latin1CaseFoldTable[256];
 
 private:
     template<typename CharType> static size_t allocationSize(unsigned length)
     {
         RELEASE_ASSERT(length <= ((std::numeric_limits<unsigned>::max() - sizeof(StringImpl)) / sizeof(CharType)));
         return sizeof(StringImpl) + length * sizeof(CharType);
     }
 
+    PassRefPtr<StringImpl> replace(UChar pattern, const LChar* replacement, unsigned replacementLength);
+    PassRefPtr<StringImpl> replace(UChar pattern, const UChar* replacement, unsigned replacementLength);
+
     template <class UCharPredicate> PassRefPtr<StringImpl> stripMatchedCharacters(UCharPredicate);
     template <typename CharType, class UCharPredicate> PassRefPtr<StringImpl> simplifyMatchedCharactersToSpace(UCharPredicate, StripBehavior);
     NEVER_INLINE unsigned hashSlowCase() const;
 
 #ifdef STRING_STATS
     static StringStats m_stringStats;
 #endif
 
     static unsigned m_highestStaticStringLength;
 
@@ skipping 281 matching lines @@
 using WTF::TextCaseASCIIInsensitive;
 using WTF::TextCaseInsensitive;
 using WTF::TextCaseSensitive;
 using WTF::TextCaseSensitivity;
 using WTF::equal;
 using WTF::equalNonNull;
 using WTF::lengthOfNullTerminatedString;
 using WTF::reverseFind;
 
 #endif