Use StringView for String::replace.

third_party/WebKit/Source/wtf/text/WTFString.h

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 201 matching lines @@
         { return m_impl ? DISPATCH_CASE_OP(caseSensitivity, m_impl->endsWith, (suffix)) : suffix.isEmpty(); }
     bool endsWith(UChar character) const
         { return m_impl ? m_impl->endsWith(character) : false; }
 
     void append(const StringView&);
     void append(LChar);
     void append(char c) { append(static_cast<LChar>(c)); }
     void append(UChar);
     void insert(const StringView&, unsigned pos);
 
-    String& replace(UChar a, UChar b)
+    // TODO(esprehn): replace strangely both modifies this String *and* return a
+    // value. It should only do one of those.
+    String& replace(UChar pattern, UChar replacement)
     {
         if (m_impl)
-            m_impl = m_impl->replace(a, b);
+            m_impl = m_impl->replace(pattern, replacement);
         return *this;
     }
-    String& replace(UChar a, const String& b)
+    String& replace(UChar pattern, const StringView& replacement)
     {
         if (m_impl)
-            m_impl = m_impl->replace(a, b.impl());
+            m_impl = m_impl->replace(pattern, replacement);
         return *this;
     }
-    String& replace(const String& a, const String& b)
+    String& replace(const StringView& pattern, const StringView& replacement)
     {
         if (m_impl)
-            m_impl = m_impl->replace(a.impl(), b.impl());
+            m_impl = m_impl->replace(pattern, replacement);
         return *this;
     }
-    String& replace(unsigned index, unsigned len, const String& b)
+    String& replace(unsigned index, unsigned lengthToReplace, const StringView& replacement)
     {
         if (m_impl)
-            m_impl = m_impl->replace(index, len, b.impl());
+            m_impl = m_impl->replace(index, lengthToReplace, replacement);
         return *this;
     }
 
-    ALWAYS_INLINE String& replace(UChar a, const char* characters)
-    {
-        ASSERT(characters);
-        if (m_impl)
-            m_impl = m_impl->replace(a, characters, strlen(characters));
-        return *this;
-    }
-
     void fill(UChar c)
     {
         if (m_impl)
             m_impl = m_impl->fill(c);
     }
 
     void ensure16Bit();
 
     void truncate(unsigned len);
     void remove(unsigned pos, int len = 1);
@@ skipping 322 matching lines @@
 using WTF::emptyString16Bit;
 using WTF::append;
 using WTF::charactersAreAllASCII;
 using WTF::equal;
 using WTF::find;
 using WTF::isAllSpecialCharacters;
 using WTF::isSpaceOrNewline;
 
 #include "wtf/text/AtomicString.h"
 #endif // WTFString_h