Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2241463002: Update bookmark suggestions also after undismiss/delete. (Closed)

Created:
4 years, 4 months ago by jkrcal
Modified:
4 years, 4 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bookmark suggestions also after undismiss/delete. The CL makes the bookmark suggestion provider react to more corner-case events: - it updates the list if a relevant bookmark is undismissed (from chrome://snippets-internals) - it updates the list if a relevant bookmark is deleted. The CL also slightly simplifies fetching recent bookmarks in bookmark_last_visit_utils.cc. BUG=631475 Committed: https://crrev.com/6fa8d8e9ed67273296a29654de3dbd5facdc1091 Cr-Commit-Position: refs/heads/master@{#411361}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Marc's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -14 lines) Patch
M components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc View 1 3 chunks +16 lines, -11 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 1 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jkrcal
Marc, PTAL! (Sorry for the amount of CLs targeted at you, you again seem like ...
4 years, 4 months ago (2016-08-11 15:07:43 UTC) #2
Marc Treib
lgtm https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h File components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h (right): https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h#newcode36 components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h:36: base::Time GetLastVisitDateForNotDismissedBookmark( Hm, not super happy with this ...
4 years, 4 months ago (2016-08-11 15:24:54 UTC) #3
jkrcal
Thanks, Marc! https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h File components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h (right): https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h#newcode36 components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h:36: base::Time GetLastVisitDateForNotDismissedBookmark( On 2016/08/11 15:24:54, Marc Treib ...
4 years, 4 months ago (2016-08-11 15:41:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241463002/20001
4 years, 4 months ago (2016-08-11 15:42:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 16:59:02 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 17:00:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fa8d8e9ed67273296a29654de3dbd5facdc1091
Cr-Commit-Position: refs/heads/master@{#411361}

Powered by Google App Engine
This is Rietveld 408576698