Update bookmark suggestions also after undismiss/delete.

Update bookmark suggestions also after undismiss/delete.

The CL makes the bookmark suggestion provider react to more corner-case
events:
 - it updates the list if a relevant bookmark is undismissed (from
   chrome://snippets-internals)
 - it updates the list if a relevant bookmark is deleted.

The CL also slightly simplifies fetching recent bookmarks in
bookmark_last_visit_utils.cc.

BUG=631475
Committed: https://crrev.com/6fa8d8e9ed67273296a29654de3dbd5facdc1091
Cr-Commit-Position: refs/heads/master@{#411361}

[jkrcal, 2016-08-11 15:07:42]

jkrcal@chromium.org changed reviewers:
+ treib@chromium.org

[jkrcal, 2016-08-11 15:07:43]

Marc, PTAL!

(Sorry for the amount of CLs targeted at you, you again seem like the most
relevant person given what you've reviewed before.)

[Marc Treib, 2016-08-11 15:24:54]

lgtm

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
File components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h (right):

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h:36: base::Time
GetLastVisitDateForNotDismissedBookmark(
Hm, not super happy with this name, but I also can't really think of a better
one... is GetLastVisitDateForBookmarkIfNotDismissed better?

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
File components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc (right):

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc:181:
FetchBookmarks();
The bookmark might have been dismissed, but I guess at this point there's no way
to find out anymore? Or can we still get the dismissed flag somehow?

[jkrcal, 2016-08-11 15:41:35]

Thanks, Marc!

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
File components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h (right):

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h:36: base::Time
GetLastVisitDateForNotDismissedBookmark(
On 2016/08/11 15:24:54, Marc Treib wrote:
> Hm, not super happy with this name, but I also can't really think of a better
> one... is GetLastVisitDateForBookmarkIfNotDismissed better?

Better, thanks. Done.

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
File components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc (right):

https://codereview.chromium.org/2241463002/diff/1/components/ntp_snippets/boo...
components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc:181:
FetchBookmarks();
On 2016/08/11 15:24:54, Marc Treib wrote:
> The bookmark might have been dismissed, but I guess at this point there's no
way
> to find out anymore? Or can we still get the dismissed flag somehow?

The node it still valid at this point. Thus,
GetLastVisitDateForNotDismissedBookmark() returns unix epoch if it is dismissed
and the function is left 3 lines above.

[jkrcal, 2016-08-11 15:41:53]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-08-11 15:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2241463002/#ps20001
(title: "Marc's comments")

[commit-bot: I haz the power, 2016-08-11 15:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:59:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 17:00:52]

Description was changed from

==========
Update bookmark suggestions also after undismiss/delete.

The CL makes the bookmark suggestion provider react to more corner-case
events:
 - it updates the list if a relevant bookmark is undismissed (from
   chrome://snippets-internals)
 - it updates the list if a relevant bookmark is deleted.

The CL also slightly simplifies fetching recent bookmarks in
bookmark_last_visit_utils.cc.

BUG=631475
==========

to

==========
Update bookmark suggestions also after undismiss/delete.

The CL makes the bookmark suggestion provider react to more corner-case
events:
 - it updates the list if a relevant bookmark is undismissed (from
   chrome://snippets-internals)
 - it updates the list if a relevant bookmark is deleted.

The CL also slightly simplifies fetching recent bookmarks in
bookmark_last_visit_utils.cc.

BUG=631475

Committed: https://crrev.com/6fa8d8e9ed67273296a29654de3dbd5facdc1091
Cr-Commit-Position: refs/heads/master@{#411361}
==========

[commit-bot: I haz the power, 2016-08-11 17:00:53]

Patchset 2 (id:??) landed as
https://crrev.com/6fa8d8e9ed67273296a29654de3dbd5facdc1091
Cr-Commit-Position: refs/heads/master@{#411361}