Update bookmark suggestions also after undismiss/delete.

components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 132 matching lines @@
   if (fetch_requested_) {
     fetch_requested_ = false;
     FetchBookmarksInternal();
   }
 }
 
 void BookmarkSuggestionsProvider::OnWillChangeBookmarkMetaInfo(
     BookmarkModel* model,
     const BookmarkNode* node) {
   // Store the last visit date of the node that is about to change.
-  node_to_change_last_visit_date_ = GetLastVisitDateForBookmark(node);
+  node_to_change_last_visit_date_ =
+      GetLastVisitDateForNotDismissedBookmark(node);
 }
 
 void BookmarkSuggestionsProvider::BookmarkMetaInfoChanged(
     BookmarkModel* model,
     const BookmarkNode* node) {
-  base::Time time = GetLastVisitDateForBookmark(node);
+  base::Time time = GetLastVisitDateForNotDismissedBookmark(node);
   if (time == node_to_change_last_visit_date_ ||
       time < end_of_list_last_visit_date_)
     return;
 
   // Last visit date of a node has changed (and is relevant for the list), we
   // should update the suggestions.
   FetchBookmarks();
 }
 
+void BookmarkSuggestionsProvider::BookmarkNodeRemoved(
+      bookmarks::BookmarkModel* model,
+      const bookmarks::BookmarkNode* parent,
+      int old_index,
+      const bookmarks::BookmarkNode* node,
+      const std::set<GURL>& no_longer_bookmarked) {
+  if (GetLastVisitDateForNotDismissedBookmark(node) <
+      end_of_list_last_visit_date_)
+    return;
+
+  // Some node from our list got deleted, we should update the suggestions.
+  FetchBookmarks();

[Marc Treib, 2016/08/11 15:24:54]

The bookmark might have been dismissed, but I guess at this point there's no way
to find out anymore? Or can we still get the dismissed flag somehow?

[jkrcal, 2016/08/11 15:41:35]

The node it still valid at this point. Thus,
GetLastVisitDateForNotDismissedBookmark() returns unix epoch if it is dismissed
and the function is left 3 lines above.

+}
+
 ContentSuggestion BookmarkSuggestionsProvider::ConvertBookmark(
     const BookmarkNode* bookmark) {
   ContentSuggestion suggestion(
       MakeUniqueID(provided_category_, bookmark->url().spec()),
       bookmark->url());
 
   suggestion.set_title(bookmark->GetTitle());
   suggestion.set_snippet_text(base::string16());
   suggestion.set_publish_date(GetLastVisitDateForBookmark(bookmark));
   suggestion.set_publisher_name(base::UTF8ToUTF16(bookmark->url().host()));
@@ skipping 31 matching lines @@
 
 void BookmarkSuggestionsProvider::NotifyStatusChanged(
     CategoryStatus new_status) {
   if (category_status_ == new_status)
     return;
   category_status_ = new_status;
   observer()->OnCategoryStatusChanged(this, provided_category_, new_status);
 }
 
 }  // namespace ntp_snippets