Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2241463002: Update bookmark suggestions also after undismiss/delete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marc's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index f77fcd4229788a661994fbd9fea079fd9098298d..04b1231b00ee6fdeb0430fc46183cc38b3f17cb4 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -150,13 +150,14 @@ void BookmarkSuggestionsProvider::OnWillChangeBookmarkMetaInfo(
BookmarkModel* model,
const BookmarkNode* node) {
// Store the last visit date of the node that is about to change.
- node_to_change_last_visit_date_ = GetLastVisitDateForBookmark(node);
+ node_to_change_last_visit_date_ =
+ GetLastVisitDateForBookmarkIfNotDismissed(node);
}
void BookmarkSuggestionsProvider::BookmarkMetaInfoChanged(
BookmarkModel* model,
const BookmarkNode* node) {
- base::Time time = GetLastVisitDateForBookmark(node);
+ base::Time time = GetLastVisitDateForBookmarkIfNotDismissed(node);
if (time == node_to_change_last_visit_date_ ||
time < end_of_list_last_visit_date_)
return;
@@ -166,6 +167,20 @@ void BookmarkSuggestionsProvider::BookmarkMetaInfoChanged(
FetchBookmarks();
}
+void BookmarkSuggestionsProvider::BookmarkNodeRemoved(
+ bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* parent,
+ int old_index,
+ const bookmarks::BookmarkNode* node,
+ const std::set<GURL>& no_longer_bookmarked) {
+ if (GetLastVisitDateForBookmarkIfNotDismissed(node) <
+ end_of_list_last_visit_date_)
+ return;
+
+ // Some node from our list got deleted, we should update the suggestions.
+ FetchBookmarks();
+}
+
ContentSuggestion BookmarkSuggestionsProvider::ConvertBookmark(
const BookmarkNode* bookmark) {
ContentSuggestion suggestion(
« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698