Issue 2241323002: [Material][Mac] Incognito Text Color Fix in the Omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2241323002: [Material][Mac] Incognito Text Color Fix in the Omnibox (Closed)

Created:
4 years, 4 months ago by spqchan

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[Material][Mac] Incognito Text Color Fix in the Omnibox The HTTPS scheme and EV Bubble text color should be white in dark mode. BUG=634057 Review-Url: https://codereview.chromium.org/2246663002 Cr-Commit-Position: refs/heads/master@{#411822} (cherry picked from commit b27db761f7aec09d22417d962c29beb5b2200e29) Committed: https://chromium.googlesource.com/chromium/src/+/3fb21793a41d8d22293a069cf64e814db9fe6f11

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -6 lines)			Patch
M	chrome/browser/ui/cocoa/location_bar/bubble_decoration.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

4 years, 4 months ago (2016-08-15 16:50:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3fb21793a41d8d22293a069cf64e814db9fe6f11.