chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h - Issue 2241323002: [Material][Mac] Incognito Text Color Fix in the Omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h

Issue 2241323002: [Material][Mac] Incognito Text Color Fix in the Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm ('k') | chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h

diff --git a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h

index 97cd4b8e8dba47c3dddd44198d3980a874e16ec3..51be0a1d6afae00dcd96bc06ff416b7bc13c405f 100644

--- a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h

+++ b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h

@@ -52,6 +52,9 @@ class EVBubbleDecoration : public BubbleDecoration {

// Implement |BubbleDecoration|.

ui::NinePartImageIds GetBubbleImageIds() override;

+ protected:

+ NSColor* GetDarkModeTextColor() override;

private:

// The real label. BubbleDecoration's label may be elided.

base::scoped_nsobject<NSString> full_label_;