Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2246663002: [Material][Mac] Incognito Text Color Fix in the Omnibox (Closed)

Created:
4 years, 4 months ago by spqchan
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Incognito Text Color Fix in the Omnibox The HTTPS scheme and EV Bubble text color should be white in dark mode. BUG=634057 Committed: https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29 Cr-Commit-Position: refs/heads/master@{#411822}

Patch Set 1 #

Patch Set 2 : Cleaned up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
spqchan
PTAL
4 years, 4 months ago (2016-08-12 22:59:14 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-12 23:07:48 UTC) #4
spqchan
On 2016/08/12 23:07:48, Avi wrote: > lgtm thanks!
4 years, 4 months ago (2016-08-12 23:08:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246663002/20001
4 years, 4 months ago (2016-08-12 23:09:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 23:58:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 00:01:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29
Cr-Commit-Position: refs/heads/master@{#411822}

Powered by Google App Engine
This is Rietveld 408576698