Move kUseNewVKWindowBehavior switch.

Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=624521

[hariank, 2016-08-15 21:16:15]

hariank@google.com changed reviewers:
+ jam@chromium.org, oshima@chromium.org

[hariank, 2016-08-15 21:16:35]

The CQ bit was checked by hariank@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 21:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 22:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 22:17:57]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-15 22:36:30]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-08-15 22:36:31]

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h#...
ui/base/ui_base_switches.h:42: UI_BASE_EXPORT extern const char
kUseNewVKWindowBehavior[];
Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a better
place for this?

[hariank, 2016-08-15 22:52:26]

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h#...
ui/base/ui_base_switches.h:42: UI_BASE_EXPORT extern const char
kUseNewVKWindowBehavior[];
On 2016/08/15 22:36:30, sadrul wrote:
> Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a
better
> place for this?

The switch needs to be used in
src/content/browser/renderer_host/render_widget_host_view_aura.cc, which can't
use ui/keyboard.

[hariank, 2016-08-15 23:02:54]

Description was changed from

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=
==========

to

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=b/29961918
==========

[hariank, 2016-08-15 23:07:03]

Description was changed from

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=b/29961918
==========

to

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=624521
==========

[sadrul, 2016-08-16 00:03:17]

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h#...
ui/base/ui_base_switches.h:42: UI_BASE_EXPORT extern const char
kUseNewVKWindowBehavior[];
On 2016/08/15 22:52:26, hariank wrote:
> On 2016/08/15 22:36:30, sadrul wrote:
> > Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a
> better
> > place for this?
> 
> The switch needs to be used in
> src/content/browser/renderer_host/render_widget_host_view_aura.cc, which can't
> use ui/keyboard.

Interesting. Can you clarify why/how RWHVAura would use the flag?

[hariank, 2016-08-16 00:26:31]

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h#...
ui/base/ui_base_switches.h:42: UI_BASE_EXPORT extern const char
kUseNewVKWindowBehavior[];
On 2016/08/16 00:03:17, sadrul wrote:
> On 2016/08/15 22:52:26, hariank wrote:
> > On 2016/08/15 22:36:30, sadrul wrote:
> > > Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a
> > better
> > > place for this?
> > 
> > The switch needs to be used in
> > src/content/browser/renderer_host/render_widget_host_view_aura.cc, which
can't
> > use ui/keyboard.
> 
> Interesting. Can you clarify why/how RWHVAura would use the flag?

With the new VK behavior (described in
https://docs.google.com/a/google.com/document/d/1hMVJC1qdCrkTmrfC8puKu8SbSK-w...),
EnsureCaretInRect is used to move windows instead of WorkspaceLayoutManager
(which was changing the work area). Currently working on the CL for that. This
flag enables/disables this behavior.

[hariank, 2016-08-17 23:22:26]

On 2016/08/16 00:26:31, hariank wrote:
> https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h
> File ui/base/ui_base_switches.h (right):
> 
>
https://codereview.chromium.org/2241273004/diff/1/ui/base/ui_base_switches.h#...
> ui/base/ui_base_switches.h:42: UI_BASE_EXPORT extern const char
> kUseNewVKWindowBehavior[];
> On 2016/08/16 00:03:17, sadrul wrote:
> > On 2016/08/15 22:52:26, hariank wrote:
> > > On 2016/08/15 22:36:30, sadrul wrote:
> > > > Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h
a
> > > better
> > > > place for this?
> > > 
> > > The switch needs to be used in
> > > src/content/browser/renderer_host/render_widget_host_view_aura.cc, which
> can't
> > > use ui/keyboard.
> > 
> > Interesting. Can you clarify why/how RWHVAura would use the flag?
> 
> With the new VK behavior (described in
>
https://docs.google.com/a/google.com/document/d/1hMVJC1qdCrkTmrfC8puKu8SbSK-w...),
> EnsureCaretInRect is used to move windows instead of WorkspaceLayoutManager
> (which was changing the work area). Currently working on the CL for that. This
> flag enables/disables this behavior.

Hi, any update on this review? I have another CL which depends on this.

[hariank, 2016-08-19 00:53:51]

hariank@google.com changed reviewers:
+ sky@chromium.org

[sky, 2016-08-19 03:05:36]

https://codereview.chromium.org/2241273004/diff/1/ash/common/wm/workspace/wor...
File ash/common/wm/workspace/workspace_layout_manager.cc (right):

https://codereview.chromium.org/2241273004/diff/1/ash/common/wm/workspace/wor...
ash/common/wm/workspace/workspace_layout_manager.cc:134:
::switches::kUseNewVKWindowBehavior) ||
I've commented on this before, but VK is obscure. How about
kNewVirtualKeyboardBehavior?

https://codereview.chromium.org/2241273004/diff/1/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2241273004/diff/1/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_layout_manager_unittest.cc:1106: if
(!command_line->HasSwitch(::switches::kUseNewVKWindowBehavior)) {
no {} here.

[hariank, 2016-08-19 17:27:20]

https://codereview.chromium.org/2241273004/diff/1/ash/common/wm/workspace/wor...
File ash/common/wm/workspace/workspace_layout_manager.cc (right):

https://codereview.chromium.org/2241273004/diff/1/ash/common/wm/workspace/wor...
ash/common/wm/workspace/workspace_layout_manager.cc:134:
::switches::kUseNewVKWindowBehavior) ||
On 2016/08/19 03:05:36, sky wrote:
> I've commented on this before, but VK is obscure. How about
> kNewVirtualKeyboardBehavior?

Done.

https://codereview.chromium.org/2241273004/diff/1/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2241273004/diff/1/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_layout_manager_unittest.cc:1106: if
(!command_line->HasSwitch(::switches::kUseNewVKWindowBehavior)) {
On 2016/08/19 03:05:36, sky wrote:
> no {} here.

Done.

[hariank, 2016-08-19 17:27:25]

The CQ bit was checked by hariank@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 17:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 19:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:27:39]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-19 19:34:14]

LGTM

[hariank, 2016-08-19 19:36:00]

The CQ bit was checked by hariank@google.com

[commit-bot: I haz the power, 2016-08-19 19:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 19:43:31]

Description was changed from

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=624521
==========

to

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=624521

Committed: https://crrev.com/bea3c659623f74686048ffabdef9b3d3a9aaf5f0
Cr-Commit-Position: refs/heads/master@{#413213}
==========

[commit-bot: I haz the power, 2016-08-19 19:43:32]

Patchset 2 (id:??) landed as
https://crrev.com/bea3c659623f74686048ffabdef9b3d3a9aaf5f0
Cr-Commit-Position: refs/heads/master@{#413213}

[commit-bot: I haz the power, 2016-08-19 19:44:07]

Description was changed from

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=624521

Committed: https://crrev.com/bea3c659623f74686048ffabdef9b3d3a9aaf5f0
Cr-Commit-Position: refs/heads/master@{#413213}
==========

to

==========
Move kUseNewVKWindowBehavior switch.

Moves this switch from ash_switches to ui_base_switches, in preparation
for future changes to virtual keyboard behavior.

BUG=624521
==========

[commit-bot: I haz the power, 2016-08-19 19:44:09]

Committed patchset #2 (id:20001)