ui/base/ui_base_switches.h - Issue 2241273004: Move kUseNewVKWindowBehavior switch.

Side by Side Diff: ui/base/ui_base_switches.h

Issue 2241273004: Move kUseNewVKWindowBehavior switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the command-line switches used by ui/base.	5 // Defines all the command-line switches used by ui/base.

6	6

7 #ifndef UI_BASE_UI_BASE_SWITCHES_H_	7 #ifndef UI_BASE_UI_BASE_SWITCHES_H_

8 #define UI_BASE_UI_BASE_SWITCHES_H_	8 #define UI_BASE_UI_BASE_SWITCHES_H_

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 21 matching lines...) Expand all Loading...
32 UI_BASE_EXPORT extern const char kEnableTouchDragDrop[];	32 UI_BASE_EXPORT extern const char kEnableTouchDragDrop[];

33 UI_BASE_EXPORT extern const char kLang[];	33 UI_BASE_EXPORT extern const char kLang[];

34 UI_BASE_EXPORT extern const char kMaterialDesignInkDropAnimationSpeed[];	34 UI_BASE_EXPORT extern const char kMaterialDesignInkDropAnimationSpeed[];

35 UI_BASE_EXPORT extern const char kMaterialDesignInkDropAnimationSpeedFast[];	35 UI_BASE_EXPORT extern const char kMaterialDesignInkDropAnimationSpeedFast[];

36 UI_BASE_EXPORT extern const char kMaterialDesignInkDropAnimationSpeedSlow[];	36 UI_BASE_EXPORT extern const char kMaterialDesignInkDropAnimationSpeedSlow[];

37	37

38 UI_BASE_EXPORT extern const char kTopChromeMD[];	38 UI_BASE_EXPORT extern const char kTopChromeMD[];

39 UI_BASE_EXPORT extern const char kTopChromeMDMaterial[];	39 UI_BASE_EXPORT extern const char kTopChromeMDMaterial[];

40 UI_BASE_EXPORT extern const char kTopChromeMDMaterialHybrid[];	40 UI_BASE_EXPORT extern const char kTopChromeMDMaterialHybrid[];

41 UI_BASE_EXPORT extern const char kTopChromeMDNonMaterial[];	41 UI_BASE_EXPORT extern const char kTopChromeMDNonMaterial[];

	42 UI_BASE_EXPORT extern const char kUseNewVKWindowBehavior[];
	sadrul 2016/08/15 22:36:30 Is https://cs.chromium.org/chromium/src/ui/keyboar Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a better place for this? hariank 2016/08/15 22:52:26 The switch needs to be used in src/content/browser Show quoted text On 2016/08/15 22:36:30, sadrul wrote: > Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a better > place for this? The switch needs to be used in src/content/browser/renderer_host/render_widget_host_view_aura.cc, which can't use ui/keyboard. sadrul 2016/08/16 00:03:17 Interesting. Can you clarify why/how RWHVAura woul Show quoted text On 2016/08/15 22:52:26, hariank wrote: > On 2016/08/15 22:36:30, sadrul wrote: > > Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a > better > > place for this? > > The switch needs to be used in > src/content/browser/renderer_host/render_widget_host_view_aura.cc, which can't > use ui/keyboard. Interesting. Can you clarify why/how RWHVAura would use the flag? hariank 2016/08/16 00:26:31 With the new VK behavior (described in https://doc Show quoted text On 2016/08/16 00:03:17, sadrul wrote: > On 2016/08/15 22:52:26, hariank wrote: > > On 2016/08/15 22:36:30, sadrul wrote: > > > Is https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_switches.h a > > better > > > place for this? > > > > The switch needs to be used in > > src/content/browser/renderer_host/render_widget_host_view_aura.cc, which can't > > use ui/keyboard. > > Interesting. Can you clarify why/how RWHVAura would use the flag? With the new VK behavior (described in https://docs.google.com/a/google.com/document/d/1hMVJC1qdCrkTmrfC8puKu8SbSK-w...), EnsureCaretInRect is used to move windows instead of WorkspaceLayoutManager (which was changing the work area). Currently working on the CL for that. This flag enables/disables this behavior.
42 UI_BASE_EXPORT extern const char kExtendMdToSecondaryUi[];	43 UI_BASE_EXPORT extern const char kExtendMdToSecondaryUi[];

43	44

44 } // namespace switches	45 } // namespace switches

45	46

46 #endif // UI_BASE_UI_BASE_SWITCHES_H_	47 #endif // UI_BASE_UI_BASE_SWITCHES_H_

OLD	NEW