Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: ash/shelf/shelf_layout_manager.cc

Issue 2241273004: Move kUseNewVKWindowBehavior switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shelf/shelf_layout_manager.h" 5 #include "ash/shelf/shelf_layout_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <vector> 9 #include <vector>
10 10
11 #include "ash/common/ash_switches.h"
12 #include "ash/common/material_design/material_design_controller.h" 11 #include "ash/common/material_design/material_design_controller.h"
13 #include "ash/common/session/session_state_delegate.h" 12 #include "ash/common/session/session_state_delegate.h"
14 #include "ash/common/shelf/shelf_constants.h" 13 #include "ash/common/shelf/shelf_constants.h"
15 #include "ash/common/shelf/shelf_delegate.h" 14 #include "ash/common/shelf/shelf_delegate.h"
16 #include "ash/common/shelf/wm_shelf_util.h" 15 #include "ash/common/shelf/wm_shelf_util.h"
17 #include "ash/common/shell_window_ids.h" 16 #include "ash/common/shell_window_ids.h"
18 #include "ash/common/system/status_area_widget.h" 17 #include "ash/common/system/status_area_widget.h"
19 #include "ash/common/wm/fullscreen_window_finder.h" 18 #include "ash/common/wm/fullscreen_window_finder.h"
20 #include "ash/common/wm/mru_window_tracker.h" 19 #include "ash/common/wm/mru_window_tracker.h"
21 #include "ash/common/wm/window_state.h" 20 #include "ash/common/wm/window_state.h"
22 #include "ash/common/wm/wm_screen_util.h" 21 #include "ash/common/wm/wm_screen_util.h"
23 #include "ash/common/wm_lookup.h" 22 #include "ash/common/wm_lookup.h"
24 #include "ash/common/wm_root_window_controller.h" 23 #include "ash/common/wm_root_window_controller.h"
25 #include "ash/common/wm_root_window_controller_observer.h" 24 #include "ash/common/wm_root_window_controller_observer.h"
26 #include "ash/common/wm_shell.h" 25 #include "ash/common/wm_shell.h"
27 #include "ash/common/wm_window.h" 26 #include "ash/common/wm_window.h"
28 #include "ash/shelf/shelf.h" 27 #include "ash/shelf/shelf.h"
29 #include "ash/shelf/shelf_layout_manager_observer.h" 28 #include "ash/shelf/shelf_layout_manager_observer.h"
30 #include "base/auto_reset.h" 29 #include "base/auto_reset.h"
31 #include "base/command_line.h" 30 #include "base/command_line.h"
32 #include "base/i18n/rtl.h" 31 #include "base/i18n/rtl.h"
32 #include "ui/base/ui_base_switches.h"
33 #include "ui/compositor/layer.h" 33 #include "ui/compositor/layer.h"
34 #include "ui/compositor/layer_animation_observer.h" 34 #include "ui/compositor/layer_animation_observer.h"
35 #include "ui/compositor/layer_animator.h" 35 #include "ui/compositor/layer_animator.h"
36 #include "ui/compositor/scoped_layer_animation_settings.h" 36 #include "ui/compositor/scoped_layer_animation_settings.h"
37 #include "ui/display/display.h" 37 #include "ui/display/display.h"
38 #include "ui/display/screen.h" 38 #include "ui/display/screen.h"
39 #include "ui/events/event.h" 39 #include "ui/events/event.h"
40 #include "ui/events/event_handler.h" 40 #include "ui/events/event_handler.h"
41 #include "ui/keyboard/keyboard_controller.h" 41 #include "ui/keyboard/keyboard_controller.h"
42 #include "ui/keyboard/keyboard_util.h" 42 #include "ui/keyboard/keyboard_util.h"
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 } 432 }
433 433
434 void ShelfLayoutManager::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) { 434 void ShelfLayoutManager::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) {
435 bool keyboard_is_about_to_hide = false; 435 bool keyboard_is_about_to_hide = false;
436 if (new_bounds.IsEmpty() && !keyboard_bounds_.IsEmpty()) 436 if (new_bounds.IsEmpty() && !keyboard_bounds_.IsEmpty())
437 keyboard_is_about_to_hide = true; 437 keyboard_is_about_to_hide = true;
438 // If new window behavior flag enabled and in non-sticky mode, do not change 438 // If new window behavior flag enabled and in non-sticky mode, do not change
439 // the work area. 439 // the work area.
440 bool change_work_area = 440 bool change_work_area =
441 (!base::CommandLine::ForCurrentProcess()->HasSwitch( 441 (!base::CommandLine::ForCurrentProcess()->HasSwitch(
442 switches::kAshUseNewVKWindowBehavior) || 442 ::switches::kUseNewVirtualKeyboardBehavior) ||
443 keyboard::KeyboardController::GetInstance()->get_lock_keyboard()); 443 keyboard::KeyboardController::GetInstance()->get_lock_keyboard());
444 444
445 keyboard_bounds_ = new_bounds; 445 keyboard_bounds_ = new_bounds;
446 LayoutShelfAndUpdateBounds(change_work_area); 446 LayoutShelfAndUpdateBounds(change_work_area);
447 447
448 // On login screen if keyboard has been just hidden, update bounds just once 448 // On login screen if keyboard has been just hidden, update bounds just once
449 // but ignore target_bounds.work_area_insets since shelf overlaps with login 449 // but ignore target_bounds.work_area_insets since shelf overlaps with login
450 // window. 450 // window.
451 if (WmShell::Get()->GetSessionStateDelegate()->IsUserSessionBlocked() && 451 if (WmShell::Get()->GetSessionStateDelegate()->IsUserSessionBlocked() &&
452 keyboard_is_about_to_hide) { 452 keyboard_is_about_to_hide) {
(...skipping 724 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 gesture_drag_status_ = GESTURE_DRAG_NONE; 1177 gesture_drag_status_ = GESTURE_DRAG_NONE;
1178 } 1178 }
1179 1179
1180 int ShelfLayoutManager::GetShelfInsetsForAutoHide() const { 1180 int ShelfLayoutManager::GetShelfInsetsForAutoHide() const {
1181 if (invisible_auto_hide_shelf_) 1181 if (invisible_auto_hide_shelf_)
1182 return 0; 1182 return 0;
1183 return GetShelfConstant(SHELF_INSETS_FOR_AUTO_HIDE); 1183 return GetShelfConstant(SHELF_INSETS_FOR_AUTO_HIDE);
1184 } 1184 }
1185 1185
1186 } // namespace ash 1186 } // namespace ash
OLDNEW
« no previous file with comments | « ash/common/wm/workspace/workspace_layout_manager.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698