Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: content/common/ssl_status_serialization.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A patchset that actually works Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/ssl_status_serialization.cc
diff --git a/content/common/ssl_status_serialization.cc b/content/common/ssl_status_serialization.cc
index a105e7ea450fcd953edec497eeb1a87b32eb00c7..1d3d3abc0a7f01055b8e1aaf5089542c1bed0585 100644
--- a/content/common/ssl_status_serialization.cc
+++ b/content/common/ssl_status_serialization.cc
@@ -31,8 +31,9 @@ bool CheckSecurityStyle(int security_style) {
bool CheckSCTStatus(uint32_t sct_status) {
switch (sct_status) {
case net::ct::SCT_STATUS_LOG_UNKNOWN:
- case net::ct::SCT_STATUS_INVALID:
+ case net::ct::SCT_STATUS_INVALID_SIGNATURE:
case net::ct::SCT_STATUS_OK:
+ case net::ct::SCT_STATUS_INVALID_TIMESTAMP:
case net::ct::SCT_STATUS_MAX:
eroman 2016/08/15 19:20:22 Why is MAX considered valid? From the definition:
Eran Messeri 2016/08/16 14:17:18 (1) MAX shouldn't be considered valid - I've moved
return true;
case net::ct::SCT_STATUS_NONE:

Powered by Google App Engine
This is Rietveld 408576698