content/common/ssl_status_serialization_unittest.cc - Issue 2241213002: Distinguish between SCT invalidity reasons in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/ssl_status_serialization_unittest.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: A patchset that actually works Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/ssl_status_serialization_unittest.cc

diff --git a/content/common/ssl_status_serialization_unittest.cc b/content/common/ssl_status_serialization_unittest.cc

index 398a7f4f03ddfe0dec86a9890fe5320029ba324b..b44bc45ce7f73a48450ab2cf2f0004c99cd55d00 100644

--- a/content/common/ssl_status_serialization_unittest.cc

+++ b/content/common/ssl_status_serialization_unittest.cc

@@ -126,7 +126,8 @@ TEST(SSLStatusSerializationTest, DeserializeMultipleSCTStatuses) {

status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);

status.sct_statuses.push_back(net::ct::SCT_STATUS_OK);

- status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID);

+ status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID_SIGNATURE);

+ status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID_TIMESTAMP);

std::string serialized = SerializeSecurityInfo(status);

SSLStatus deserialized;