Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4193)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/website_settings/website_settings_unittest.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A patchset that actually works Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ssl/chrome_expect_ct_reporter.cc ('K') | « chrome/browser/ui/website_settings/website_settings.cc ('k') | content/common/ssl_status_serialization.cc » ('j') | content/common/ssl_status_serialization.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings_unittest.cc
diff --git a/chrome/browser/ui/website_settings/website_settings_unittest.cc b/chrome/browser/ui/website_settings/website_settings_unittest.cc
index baf675afe2669801c3521bca2e7cba51f219affa..53a4095cd03f2a7985790b94e5412e6ae7566cb6 100644
--- a/chrome/browser/ui/website_settings/website_settings_unittest.cc
+++ b/chrome/browser/ui/website_settings/website_settings_unittest.cc
@@ -617,8 +617,10 @@ TEST_F(WebsiteSettingsTest, InvalidSCTs) {
status = SetSSLCipherSuite(status, CR_TLS_RSA_WITH_AES_256_CBC_SHA256);
security_info_.connection_status = status;
- security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);
- security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);
+ security_info_.sct_verify_statuses.push_back(
+ net::ct::SCT_STATUS_INVALID_TIMESTAMP);
+ security_info_.sct_verify_statuses.push_back(
+ net::ct::SCT_STATUS_INVALID_SIGNATURE);
SetDefaultUIExpectations(mock_ui());
EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));
@@ -705,7 +707,8 @@ TEST_F(WebsiteSettingsTest, UnknownAndInvalidSCTs) {
security_info_.connection_status = status;
security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
- security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);
+ security_info_.sct_verify_statuses.push_back(
+ net::ct::SCT_STATUS_INVALID_SIGNATURE);
SetDefaultUIExpectations(mock_ui());
EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));
« chrome/browser/ssl/chrome_expect_ct_reporter.cc ('K') | « chrome/browser/ui/website_settings/website_settings.cc ('k') | content/common/ssl_status_serialization.cc » ('j') | content/common/ssl_status_serialization.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698