Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2240503002: exo: Release context provider references when main thread context is lost. (Closed)

Created:
4 years, 4 months ago by reveman
Modified:
4 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Release context provider references when main thread context is lost. This allows use to break any circular reference to the context provider instance during tear down. BUG=630625 TEST=exo_unittests --gtest_filter=GamepadTest.OnAxis (with https://codereview.chromium.org/2237723002 patched in) Committed: https://crrev.com/d0b75c385d2c1abf1ecff249d9ac4c79d157db73 Cr-Commit-Position: refs/heads/master@{#411529}

Patch Set 1 #

Patch Set 2 : exo: Release context provider references when main thread context is lost. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -87 lines) Patch
M components/exo/BUILD.gn View 1 chunk +5 lines, -6 lines 0 comments Download
M components/exo/buffer.cc View 10 chunks +119 lines, -78 lines 0 comments Download
M ui/compositor/test/context_factories_for_test.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
reveman
4 years, 4 months ago (2016-08-11 15:24:49 UTC) #2
piman
LGTM, thanks!
4 years, 4 months ago (2016-08-11 17:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240503002/1
4 years, 4 months ago (2016-08-11 17:34:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/206127)
4 years, 4 months ago (2016-08-11 17:57:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240503002/20001
4 years, 4 months ago (2016-08-11 21:50:02 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/50769)
4 years, 4 months ago (2016-08-11 22:01:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240503002/20001
4 years, 4 months ago (2016-08-12 02:10:59 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 02:48:04 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 02:50:42 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0b75c385d2c1abf1ecff249d9ac4c79d157db73
Cr-Commit-Position: refs/heads/master@{#411529}

Powered by Google App Engine
This is Rietveld 408576698