Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2250023002: test-results: bug fixes and tests for TestFile Put, PutData (Closed)

Created:
4 years, 4 months ago by nishanths
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@cl-ing_upload
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

test-results: bug fixes and tests for TestFile Put, PutData BUG= Committed: https://chromium.googlesource.com/infra/infra/+/0db9833e10f14690092af7cc3b01ee06f4d4273a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -54 lines) Patch
M go/src/infra/appengine/test-results/model/test_file.go View 5 chunks +26 lines, -19 lines 0 comments Download
M go/src/infra/appengine/test-results/model/test_file_test.go View 2 chunks +89 lines, -35 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
nishanths
PTAL. Thanks!
4 years, 4 months ago (2016-08-16 05:01:27 UTC) #3
Vadim Sh.
lgtm
4 years, 4 months ago (2016-08-16 18:24:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250023002/1
4 years, 4 months ago (2016-08-16 18:26:53 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 18:40:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/0db9833e10f14690092af7cc3b01e...

Powered by Google App Engine
This is Rietveld 408576698