chrome/android/java/res/layout/icon_row_menu_item.xml - Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/icon_row_menu_item.xml

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/four_button_menu_item.xml ('k') | chrome/android/java/res/layout/three_button_menu_item.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/icon_row_menu_item.xml

diff --git a/chrome/android/java/res/layout/four_button_menu_item.xml b/chrome/android/java/res/layout/icon_row_menu_item.xml

similarity index 81%

rename from chrome/android/java/res/layout/four_button_menu_item.xml

rename to chrome/android/java/res/layout/icon_row_menu_item.xml

index bbec6abb5e1732c95e6ccddfe7b0b47011f430c4..df361e32401424dc75fa7bf1045a95b55f7bf04e 100644

--- a/chrome/android/java/res/layout/four_button_menu_item.xml

+++ b/chrome/android/java/res/layout/icon_row_menu_item.xml

@@ -1,5 +1,5 @@

<?xml version="1.0" encoding="utf-8"?>

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file.

@@ -41,4 +41,12 @@

android:layout_weight="1"

android:background="?attr/listChoiceBackgroundIndicator"

android:scaleType="center" />

+ <org.chromium.chrome.browser.widget.TintedImageButton

+ android:id="@+id/button_five"

+ android:layout_width="0dp"

+ android:layout_height="match_parent"

+ android:layout_weight="1"

+ android:background="?attr/listChoiceBackgroundIndicator"

Theresa 2016/08/12 18:53:15 Can we define common style for these buttons?

gone 2016/08/12 19:09:19 Done.

+ android:scaleType="center" />

</LinearLayout>