Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
index 6eee512382f6dd416dc79436df859b6b1976ef5d..e57d0821434f78b9dad43910915a83e8c3d549aa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
@@ -4,13 +4,17 @@
package org.chromium.chrome.browser.appmenu;
+import android.graphics.PorterDuff;
+import android.graphics.drawable.Drawable;
import android.text.TextUtils;
import android.view.Menu;
import android.view.MenuItem;
+import org.chromium.base.CommandLine;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeFeatureList;
+import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge;
@@ -104,6 +108,22 @@ public class AppMenuPropertiesDelegate {
MenuItem bookmarkMenuItem = menu.findItem(R.id.bookmark_this_page_id);
updateBookmarkMenuItem(bookmarkMenuItem, currentTab);
+
+ MenuItem offlineMenuItem = menu.findItem(R.id.offline_page_id);
+ if (offlineMenuItem != null) {
+ if (!CommandLine.getInstance().hasSwitch(
+ ChromeSwitches.ENABLE_OFFLINE_PAGE_DOWNLOADING)) {
+ offlineMenuItem.setVisible(false);
Theresa 2016/08/12 18:53:15 If it's not enabled we don't need to do the rest o
gone 2016/08/12 19:09:19 Done.
+ }
+
+ offlineMenuItem.setEnabled(!isChromeScheme);
+ Drawable drawable = offlineMenuItem.getIcon();
+ if (drawable != null) {
+ int iconTint = mActivity.getColor(R.color.light_normal_color);
+ drawable.mutate();
+ drawable.setColorFilter(iconTint, PorterDuff.Mode.SRC_ATOP);
+ }
+ }
}
menu.findItem(R.id.downloads_menu_id)

Powered by Google App Engine
This is Rietveld 408576698