chrome/android/java/res/layout/icon_row_menu_item.xml - Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/icon_row_menu_item.xml

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/four_button_menu_item.xml ('k') | chrome/android/java/res/layout/three_button_menu_item.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="match_parent"	8 android:layout_width="match_parent"

9 android:layout_height="?android:attr/listPreferredItemHeightSmall"	9 android:layout_height="?android:attr/listPreferredItemHeightSmall"

10 android:layout_gravity="top\|start"	10 android:layout_gravity="top\|start"

11 android:orientation="horizontal">	11 android:orientation="horizontal">

12	12

(...skipping 21 matching lines...) Expand all Loading...
34 android:background="?attr/listChoiceBackgroundIndicator"	34 android:background="?attr/listChoiceBackgroundIndicator"

35 android:scaleType="center" />	35 android:scaleType="center" />

36	36

37 <org.chromium.chrome.browser.widget.TintedImageButton	37 <org.chromium.chrome.browser.widget.TintedImageButton

38 android:id="@+id/button_four"	38 android:id="@+id/button_four"

39 android:layout_width="0dp"	39 android:layout_width="0dp"

40 android:layout_height="match_parent"	40 android:layout_height="match_parent"

41 android:layout_weight="1"	41 android:layout_weight="1"

42 android:background="?attr/listChoiceBackgroundIndicator"	42 android:background="?attr/listChoiceBackgroundIndicator"

43 android:scaleType="center" />	43 android:scaleType="center" />

	44

	45 <org.chromium.chrome.browser.widget.TintedImageButton

	46 android:id="@+id/button_five"

	47 android:layout_width="0dp"

	48 android:layout_height="match_parent"

	49 android:layout_weight="1"

	50 android:background="?attr/listChoiceBackgroundIndicator"
	Theresa 2016/08/12 18:53:15 Can we define common style for these buttons? Can we define common style for these buttons? gone 2016/08/12 19:09:19 Done. Show quoted text On 2016/08/12 18:53:15, Theresa Wellington wrote: > Can we define common style for these buttons? Done.
	51 android:scaleType="center" />

44 </LinearLayout>	52 </LinearLayout>

OLD	NEW