Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/wtf/text/StringConcatenate.h

Issue 2240233002: Print additional message for RELEASE_ASSERT in builds used for fuzzing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to #elif block (avoid changing debug builds) and use LOG_IF() instead of WTFLogAlways(). Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringConcatenate.h
diff --git a/third_party/WebKit/Source/wtf/text/StringConcatenate.h b/third_party/WebKit/Source/wtf/text/StringConcatenate.h
index 63a7c4e296292295007d7a15bff37fa10dac4e9e..b9c6d948a08e6e23d2ef7e9f5f4fb1e90adab565 100644
--- a/third_party/WebKit/Source/wtf/text/StringConcatenate.h
+++ b/third_party/WebKit/Source/wtf/text/StringConcatenate.h
@@ -171,7 +171,7 @@ public:
bool is8Bit() { return false; }
- NO_RETURN_DUE_TO_CRASH void writeTo(LChar*)
+ void writeTo(LChar*)
mmoroz 2016/08/25 10:45:53 Another approach could be: NO_RETURN_DUE_TO_C
tkent 2016/08/25 12:54:06 IMO, it's ok to remove NO_RETURN_DE_TO_CRASH here.
{
RELEASE_ASSERT(false);
}
« third_party/WebKit/Source/wtf/Assertions.h ('K') | « third_party/WebKit/Source/wtf/Assertions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698