third_party/WebKit/Source/wtf/Assertions.h - Issue 2240233002: Print additional message for RELEASE_ASSERT in builds used for fuzzing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/Assertions.h

Issue 2240233002: Print additional message for RELEASE_ASSERT in builds used for fuzzing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move to #elif block (avoid changing debug builds) and use LOG_IF() instead of WTFLogAlways(). Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/Assertions.h

diff --git a/third_party/WebKit/Source/wtf/Assertions.h b/third_party/WebKit/Source/wtf/Assertions.h

index 750ee7e3c975f9a027b64fe41070093370714ea1..5e2b437a3bf52909f70c15cf5b33d047c7fa3d91 100644

--- a/third_party/WebKit/Source/wtf/Assertions.h

+++ b/third_party/WebKit/Source/wtf/Assertions.h

@@ -263,6 +263,8 @@ private:

// RELEASE_ASSERT is deprecated. We should use CHECK() instead.

#if ENABLE(ASSERT)

#define RELEASE_ASSERT(assertion) ASSERT(assertion)

+#elif defined(ADDRESS_SANITIZER)

+#define RELEASE_ASSERT(condition) LOG_IF(FATAL, !(condition)) << "Release assert failed: " #condition ". "

tkent 2016/08/25 12:54:06 We deprecated RELEASE_ASSERT(), and are replacing

mmoroz 2016/08/25 13:13:45 Good point! +1 to replace 'Release assert' -> 'Sec

mmoroz 2016/08/25 13:39:50 Hm, on ClusterFuzz side we mark 'Security CHECK fa

#else

#define RELEASE_ASSERT(assertion) (UNLIKELY(!(assertion)) ? (IMMEDIATE_CRASH()) : (void)0)

#endif

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/StringConcatenate.h » ('j') | third_party/WebKit/Source/wtf/text/StringConcatenate.h » ('J')