Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: third_party/WebKit/Source/wtf/text/StringConcatenate.h

Issue 2240233002: Print additional message for RELEASE_ASSERT in builds used for fuzzing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to #elif block (avoid changing debug builds) and use LOG_IF() instead of WTFLogAlways(). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 template<> 164 template<>
165 class WTF_EXPORT StringTypeAdapter<const UChar*> { 165 class WTF_EXPORT StringTypeAdapter<const UChar*> {
166 DISALLOW_NEW(); 166 DISALLOW_NEW();
167 public: 167 public:
168 StringTypeAdapter(const UChar* buffer); 168 StringTypeAdapter(const UChar* buffer);
169 169
170 unsigned length() { return m_length; } 170 unsigned length() { return m_length; }
171 171
172 bool is8Bit() { return false; } 172 bool is8Bit() { return false; }
173 173
174 NO_RETURN_DUE_TO_CRASH void writeTo(LChar*) 174 void writeTo(LChar*)
mmoroz 2016/08/25 10:45:53 Another approach could be: NO_RETURN_DUE_TO_C
tkent 2016/08/25 12:54:06 IMO, it's ok to remove NO_RETURN_DE_TO_CRASH here.
175 { 175 {
176 RELEASE_ASSERT(false); 176 RELEASE_ASSERT(false);
177 } 177 }
178 178
179 void writeTo(UChar* destination); 179 void writeTo(UChar* destination);
180 180
181 private: 181 private:
182 const UChar* m_buffer; 182 const UChar* m_buffer;
183 unsigned m_length; 183 unsigned m_length;
184 }; 184 };
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 result += adapter1.length(); 348 result += adapter1.length();
349 adapter2.writeTo(result); 349 adapter2.writeTo(result);
350 350
351 return resultImpl.release(); 351 return resultImpl.release();
352 } 352 }
353 353
354 } // namespace WTF 354 } // namespace WTF
355 355
356 #include "wtf/text/StringOperators.h" 356 #include "wtf/text/StringOperators.h"
357 #endif 357 #endif
OLDNEW
« third_party/WebKit/Source/wtf/Assertions.h ('K') | « third_party/WebKit/Source/wtf/Assertions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698