components/tracing/test/fake_scattered_buffer.h - Issue 2240043004: Tracing V2: Fully-functional plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/test/fake_scattered_buffer.h

Issue 2240043004: Tracing V2: Fully-functional plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix use after free in tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/test/fake_scattered_buffer.h

diff --git a/components/tracing/test/fake_scattered_buffer.h b/components/tracing/test/fake_scattered_buffer.h

index 5089765d2f208b035d9f6ddafbeb064501bc261c..25acddf84a14f5d728e21ae316920b7b2db75515 100644

--- a/components/tracing/test/fake_scattered_buffer.h

+++ b/components/tracing/test/fake_scattered_buffer.h

@@ -28,6 +28,7 @@ class FakeScatteredBuffer : public ScatteredStreamWriter::Delegate {

std::string GetChunkAsString(int chunk_index);

+ void GetBytes(size_t start, size_t length, uint8_t* buf);

std::string GetBytesAsString(size_t start, size_t length);

const std::vector<std::unique_ptr<uint8_t[]>>& chunks() const {