Tracing V2: Fully-functional plugin.

components/tracing/test/fake_scattered_buffer.cc

Index: components/tracing/test/fake_scattered_buffer.cc
diff --git a/components/tracing/test/fake_scattered_buffer.cc b/components/tracing/test/fake_scattered_buffer.cc
index 18e16e73f9cc8dccddcb3244404bed036630e096..598cbe6377e2700570a3f2dac83c7efbb81bbb38 100644
--- a/components/tracing/test/fake_scattered_buffer.cc
+++ b/components/tracing/test/fake_scattered_buffer.cc
@@ -29,6 +29,18 @@ std::string FakeScatteredBuffer::GetChunkAsString(int chunk_index) {
   return base::HexEncode(chunks_[chunk_index].get(), chunk_size_);
 }
 
+void FakeScatteredBuffer::GetBytes(size_t start, size_t length, uint8_t* buf) {
+  ASSERT_LE(start + length, chunks_.size() * chunk_size_);
+  for (size_t pos = 0; pos < length; ++pos) {
+    size_t chunk_index = (start + pos) / chunk_size_;
+    size_t chunk_offset = (start + pos) % chunk_size_;
+    if (chunk_index >= chunks_.size()) {

[alph, 2016/08/22 22:48:35]

nit: looks redundant provided the ASSERT above.

[kraynov, 2016/08/23 12:43:49]

Done.

+      FAIL();
+    }
+    buf[pos] = chunks_[chunk_index].get()[chunk_offset];
+  }
+}
+
 std::string FakeScatteredBuffer::GetBytesAsString(size_t start, size_t length) {
   std::string hexstr;
   EXPECT_LE(start + length, chunks_.size() * chunk_size_);