components/tracing/core/proto_zero_message_handle.cc - Issue 2240043004: Tracing V2: Fully-functional plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/core/proto_zero_message_handle.cc

Issue 2240043004: Tracing V2: Fully-functional plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix use after free in tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/core/proto_zero_message_handle.cc

diff --git a/components/tracing/core/proto_zero_message_handle.cc b/components/tracing/core/proto_zero_message_handle.cc

index 1906cf24721cb00d4b291963c8c3f5f3f2d3992d..1d890c0198681f224d61fede9fbcd68685dde8a3 100644

--- a/components/tracing/core/proto_zero_message_handle.cc

+++ b/components/tracing/core/proto_zero_message_handle.cc

@@ -57,6 +57,7 @@ void ProtoZeroMessageHandleBase::Move(ProtoZeroMessageHandleBase* other) {

// will manifest as a segfault when dereferencing |message_| below) to avoid a

// useless null-check.

message_ = other->message_;

+ sealed_fields_ = std::move(other->sealed_fields_);

other->message_ = nullptr;

#if DCHECK_IS_ON()

message_->set_handle(this);