Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10561)

Unified Diff: chrome/test/data/webui/settings/people_page_test.js

Issue 2239973002: MD Settings: Use dom-if for the profile disconnect dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/people_page_test.js
diff --git a/chrome/test/data/webui/settings/people_page_test.js b/chrome/test/data/webui/settings/people_page_test.js
index 424e4be44ca773c3325fb05cf18446feab95f5f6..e2b14e58d2f5a45e52b44df9883a1c4dd5907b58 100644
--- a/chrome/test/data/webui/settings/people_page_test.js
+++ b/chrome/test/data/webui/settings/people_page_test.js
@@ -157,11 +157,11 @@ cr.define('settings_people_page', function() {
MockInteractions.tap(disconnectButton);
Polymer.dom.flush();
+ }).then(function() {
+ assertTrue(!!peoplePage.$$('#disconnectDialog').open);
+ assertFalse(peoplePage.$$('#deleteProfile').hidden);
- assertTrue(peoplePage.$.disconnectDialog.open);
- assertFalse(peoplePage.$.deleteProfile.hidden);
-
- var disconnectConfirm = peoplePage.$.disconnectConfirm;
+ var disconnectConfirm = peoplePage.$$('#disconnectConfirm');
assertTrue(!!disconnectConfirm);
assertFalse(disconnectConfirm.hidden);
MockInteractions.tap(disconnectConfirm);
@@ -178,15 +178,15 @@ cr.define('settings_people_page', function() {
});
Polymer.dom.flush();
- assertFalse(peoplePage.$.disconnectDialog.open);
+ assertFalse(!!peoplePage.$$('#disconnectDialog'));
MockInteractions.tap(disconnectButton);
Polymer.dom.flush();
-
- assertTrue(peoplePage.$.disconnectDialog.open);
- assertTrue(peoplePage.$.deleteProfile.hidden);
+ }).then(function() {
+ assertTrue(peoplePage.$$('#disconnectDialog').open);
+ assertTrue(peoplePage.$$('#deleteProfile').hidden);
var disconnectManagedProfileConfirm =
- peoplePage.$.disconnectManagedProfileConfirm;
+ peoplePage.$$('#disconnectManagedProfileConfirm');
assertTrue(!!disconnectManagedProfileConfirm);
assertFalse(disconnectManagedProfileConfirm.hidden);

Powered by Google App Engine
This is Rietveld 408576698