Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2239973002: MD Settings: Use dom-if for the profile disconnect dialog. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
tommycli, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Use dom-if for the profile disconnect dialog. BUG=597347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2239973002 Cr-Commit-Position: refs/heads/master@{#460165} Committed: https://chromium.googlesource.com/chromium/src/+/f412dc8f3c6aacbc56e51b4b17d0f5f765208fb2

Patch Set 1 #

Patch Set 2 : Fix test. #

Total comments: 2

Patch Set 3 : Fix test. #

Patch Set 4 : Nit. #

Total comments: 7

Patch Set 5 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -66 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 2 3 4 1 chunk +41 lines, -35 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 2 3 4 6 chunks +17 lines, -9 lines 0 comments Download
M chrome/test/data/webui/settings/people_page_test.js View 1 2 3 6 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 36 (25 generated)
dpapad
I thought about moving the dialog to its own file, in accordance with most other ...
4 years, 4 months ago (2016-08-12 00:01:58 UTC) #8
Dan Beam
lgtm https://codereview.chromium.org/2239973002/diff/20001/chrome/browser/resources/settings/people_page/people_page.html File chrome/browser/resources/settings/people_page/people_page.html (right): https://codereview.chromium.org/2239973002/diff/20001/chrome/browser/resources/settings/people_page/people_page.html#newcode294 chrome/browser/resources/settings/people_page/people_page.html:294: <div inner-h-t-m-l="[[getDisconnectExplanationHtml_(syncStatus.domain)]]"> wrap https://codereview.chromium.org/2239973002/diff/20001/chrome/browser/resources/settings/people_page/people_page.html#newcode310 chrome/browser/resources/settings/people_page/people_page.html:310: <paper-button id="disconnectManagedProfileConfirm" class="action-button" ...
4 years, 4 months ago (2016-08-12 20:35:42 UTC) #11
dpapad
Not sure what happened to this CL. Looking at the date, I probably sent it ...
3 years, 9 months ago (2017-03-24 18:35:24 UTC) #12
dpapad
Adding you as a reviewer since the existing LG was submitted many months ago, and ...
3 years, 9 months ago (2017-03-25 00:19:46 UTC) #19
Dan Beam
lgtm but get tommycli to look as well https://codereview.chromium.org/2239973002/diff/80001/chrome/browser/resources/settings/people_page/people_page.js File chrome/browser/resources/settings/people_page/people_page.js (right): https://codereview.chromium.org/2239973002/diff/80001/chrome/browser/resources/settings/people_page/people_page.js#newcode194 chrome/browser/resources/settings/people_page/people_page.js:194: this.async(function() ...
3 years, 9 months ago (2017-03-25 11:26:04 UTC) #22
tommycli
lgtm sans some nits https://codereview.chromium.org/2239973002/diff/80001/chrome/browser/resources/settings/people_page/people_page.js File chrome/browser/resources/settings/people_page/people_page.js (right): https://codereview.chromium.org/2239973002/diff/80001/chrome/browser/resources/settings/people_page/people_page.js#newcode84 chrome/browser/resources/settings/people_page/people_page.js:84: showingDisconnectDialog_: Boolean, I think the ...
3 years, 9 months ago (2017-03-27 16:11:23 UTC) #23
dpapad
https://codereview.chromium.org/2239973002/diff/80001/chrome/browser/resources/settings/people_page/people_page.js File chrome/browser/resources/settings/people_page/people_page.js (right): https://codereview.chromium.org/2239973002/diff/80001/chrome/browser/resources/settings/people_page/people_page.js#newcode84 chrome/browser/resources/settings/people_page/people_page.js:84: showingDisconnectDialog_: Boolean, On 2017/03/27 at 16:11:23, tommycli wrote: > ...
3 years, 9 months ago (2017-03-27 20:47:40 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239973002/100001
3 years, 9 months ago (2017-03-28 01:01:48 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/415935)
3 years, 9 months ago (2017-03-28 02:25:36 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239973002/100001
3 years, 8 months ago (2017-03-28 17:30:42 UTC) #33
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 18:00:06 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f412dc8f3c6aacbc56e51b4b17d0...

Powered by Google App Engine
This is Rietveld 408576698