Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2927)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2239973002: MD Settings: Use dom-if for the profile disconnect dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.js
diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js
index da7961a3529deb418d5bf444cc81cf6f6818861d..568e9a0f94636603de2f83bc54b7e52964881bb9 100644
--- a/chrome/browser/resources/settings/people_page/people_page.js
+++ b/chrome/browser/resources/settings/people_page/people_page.js
@@ -53,6 +53,9 @@ Polymer({
value: function() {
return settings.SyncBrowserProxyImpl.getInstance();
},
+
+ /** @private */
+ showingDisconnectDialog_: Boolean,
},
<if expr="chromeos">
@@ -217,21 +220,29 @@ Polymer({
/** @private */
onDisconnectTap_: function() {
- this.$.disconnectDialog.showModal();
+ this.showingDisconnectDialog_ = true;
+ this.async(function() {
+ this.$$('#disconnectDialog').showModal();
+ }.bind(this));
},
/** @private */
onDisconnectCancel_: function() {
- this.$.disconnectDialog.close();
+ this.$$('#disconnectDialog').close();
},
/** @private */
onDisconnectConfirm_: function() {
var deleteProfile = !!this.syncStatus.domain ||
- (this.$.deleteProfile && this.$.deleteProfile.checked);
+ (this.$$('#deleteProfile') && this.$$('#deleteProfile').checked);
this.syncBrowserProxy_.signOut(deleteProfile);
- this.$.disconnectDialog.close();
+ this.$$('#disconnectDialog').close();
+ },
+
+ /** @private */
+ onDisconnectDialogClosed_: function() {
+ this.showingDisconnectDialog_ = false;
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698