Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2657)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2239973002: MD Settings: Use dom-if for the profile disconnect dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 80a0c9f23b793aff165185514de6eec598430437..9086deb62e41cdf4227b345157a2efb8e3db22fd 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -374,45 +374,51 @@
</if>
</settings-animated-pages>
- <dialog is="cr-dialog" id="disconnectDialog" on-close="onDisconnectClosed_"
- close-text="$i18n{close}" ignore-popstate>
- <div class="title">$i18n{syncDisconnectTitle}</div>
- <div class="body">
- <div inner-h-t-m-l="[[getDisconnectExplanationHtml_(syncStatus.domain)]]">
+ <template is="dom-if" if="[[showDisconnectDialog_]]" restamp>
+ <dialog is="cr-dialog" id="disconnectDialog" ignore-popstate
+ on-close="onDisconnectClosed_" close-text="$i18n{close}">
+ <div class="title">$i18n{syncDisconnectTitle}</div>
+ <div class="body">
+ <div inner-h-t-m-l="[[
+ getDisconnectExplanationHtml_(syncStatus.domain)]]">
+ </div>
+ </div>
+ <div class="button-container">
+ <paper-button on-tap="onDisconnectCancel_" class="cancel-button">
+ $i18n{cancel}
+ </paper-button>
+ <paper-button id="disconnectConfirm" class="action-button"
+ hidden="[[syncStatus.domain]]" on-tap="onDisconnectConfirm_">
+ $i18n{syncDisconnect}
+ </paper-button>
+ <paper-button id="disconnectManagedProfileConfirm"
+ class="action-button" hidden="[[!syncStatus.domain]]"
+ on-tap="onDisconnectConfirm_">
+ $i18n{syncDisconnectConfirm}
+ </paper-button>
</div>
- </div>
- <div class="button-container">
- <paper-button on-tap="onDisconnectCancel_" class="cancel-button">
- $i18n{cancel}
- </paper-button>
- <paper-button id="disconnectConfirm" class="action-button"
- hidden="[[syncStatus.domain]]" on-tap="onDisconnectConfirm_">
- $i18n{syncDisconnect}
- </paper-button>
- <paper-button id="disconnectManagedProfileConfirm" class="action-button"
- hidden="[[!syncStatus.domain]]" on-tap="onDisconnectConfirm_">
- $i18n{syncDisconnectConfirm}
- </paper-button>
- </div>
<if expr="(not chromeos and is_posix) or is_win or is_macosx">
- <template is="dom-if" if="[[!syncStatus.domain]]">
- <div class="footer border-top-divider">
- <div class="settings-box first">
- <paper-checkbox id="deleteProfile" class="start"
- checked="{{deleteProfile_}}">
- $i18n{syncDisconnectDeleteProfile}
- </paper-checkbox>
- <cr-expand-button expanded="{{deleteProfileWarningVisible_}}"
- alt="$i18n{deleteProfileWarningExpandA11yLabel}">
- </cr-expand-button>
+ <template is="dom-if" if="[[!syncStatus.domain]]">
+ <div class="footer border-top-divider">
+ <div class="settings-box first">
+ <paper-checkbox id="deleteProfile" class="start"
+ checked="{{deleteProfile_}}">
+ $i18n{syncDisconnectDeleteProfile}
+ </paper-checkbox>
+ <cr-expand-button expanded="{{deleteProfileWarningVisible_}}"
+ alt="$i18n{deleteProfileWarningExpandA11yLabel}">
+ </cr-expand-button>
+ </div>
+ <iron-collapse opened="[[deleteProfileWarningVisible_]]">
+ <div class="delete-profile-warning">
+ [[deleteProfileWarning_]]
+ </div>
+ </iron-collapse>
</div>
- <iron-collapse opened="[[deleteProfileWarningVisible_]]">
- <div class="delete-profile-warning">[[deleteProfileWarning_]]</div>
- </iron-collapse>
- </div>
- </template>
+ </template>
</if>
- </dialog>
+ </dialog>
+ </template>
<template is="dom-if" if="[[showImportDataDialog_]]" restamp>
<settings-import-data-dialog prefs="{{prefs}}"
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698