Forward bundle product_type to the compile_xcassets tool.

Forward bundle product_type to the compile_xcassets tool.

With Xcode 8, the actool command needs to know the product_type of the
bundle that will contain the Assets.car file. Add support for forwarding
the value to the actool invocation via the compile_xcassets tool.

BUG=634373
Committed: https://crrev.com/2eb03fab2b97643f80192ec8ffe947020982f445
Cr-Commit-Position: refs/heads/master@{#411754}

[sdefresne, 2016-08-11 23:07:06]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-11 23:12:13]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[sdefresne, 2016-08-11 23:12:14]

Please take a look and send to CQ if lgty.

[sdefresne, 2016-08-11 23:17:33]

+justincohen: FYI

[brettw, 2016-08-11 23:24:02]

lgtm

[sdefresne, 2016-08-11 23:24:27]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-08-11 23:24:33]

The CQ bit was checked by sdefresne@chromium.org

[brettw, 2016-08-11 23:24:54]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-08-11 23:24:58]

Hold on, I have a comment

[commit-bot: I haz the power, 2016-08-11 23:25:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-11 23:25:57]

We need to document this new substitution in function_toolchain.cc

[sdefresne, 2016-08-11 23:26:04]

On 2016/08/11 23:24:58, brettw (ping on IM after 24h) wrote:
> Hold on, I have a comment

Sure.

[sdefresne, 2016-08-11 23:34:01]

Please take another look.

[sdefresne, 2016-08-11 23:34:07]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-11 23:46:35]

Thanks! LGTM

https://codereview.chromium.org/2239943002/diff/20001/tools/gn/function_toolc...
File tools/gn/function_toolchain.cc (right):

https://codereview.chromium.org/2239943002/diff/20001/tools/gn/function_toolc...
tools/gn/function_toolchain.cc:870: "        compiled asset catalog. Usually
correspond to the product_type\n"
Grammar: "correspond" -> "corresponds"

[commit-bot: I haz the power, 2016-08-12 00:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:22:26]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-08-12 19:38:53]

https://codereview.chromium.org/2239943002/diff/20001/tools/gn/function_toolc...
File tools/gn/function_toolchain.cc (right):

https://codereview.chromium.org/2239943002/diff/20001/tools/gn/function_toolc...
tools/gn/function_toolchain.cc:870: "        compiled asset catalog. Usually
correspond to the product_type\n"
On 2016/08/11 23:46:35, brettw (ping on IM after 24h) wrote:
> Grammar: "correspond" -> "corresponds"

Done.

[sdefresne, 2016-08-12 19:38:59]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-08-12 19:38:59]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2239943002/#ps40001
(title: "Fix grammar.")

[commit-bot: I haz the power, 2016-08-12 19:39:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:17:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-12 20:22:03]

Description was changed from

==========
Forward bundle product_type to the compile_xcassets tool.

With Xcode 8, the actool command needs to know the product_type of the
bundle that will contain the Assets.car file. Add support for forwarding
the value to the actool invocation via the compile_xcassets tool.

BUG=634373
==========

to

==========
Forward bundle product_type to the compile_xcassets tool.

With Xcode 8, the actool command needs to know the product_type of the
bundle that will contain the Assets.car file. Add support for forwarding
the value to the actool invocation via the compile_xcassets tool.

BUG=634373

Committed: https://crrev.com/2eb03fab2b97643f80192ec8ffe947020982f445
Cr-Commit-Position: refs/heads/master@{#411754}
==========

[commit-bot: I haz the power, 2016-08-12 20:22:05]

Patchset 3 (id:??) landed as
https://crrev.com/2eb03fab2b97643f80192ec8ffe947020982f445
Cr-Commit-Position: refs/heads/master@{#411754}

[Dirk Pranke, 2016-08-12 22:32:13]

lgtm