Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: tools/gn/ninja_create_bundle_target_writer.cc

Issue 2239943002: Forward bundle product_type to the compile_xcassets tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix grammar. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_create_bundle_target_writer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/ninja_create_bundle_target_writer.h" 5 #include "tools/gn/ninja_create_bundle_target_writer.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "tools/gn/filesystem_utils.h" 9 #include "tools/gn/filesystem_utils.h"
10 #include "tools/gn/ninja_utils.h" 10 #include "tools/gn/ninja_utils.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 std::set<SourceFile> asset_catalog_bundles; 157 std::set<SourceFile> asset_catalog_bundles;
158 for (const auto& source : target_->bundle_data().assets_catalog_sources()) { 158 for (const auto& source : target_->bundle_data().assets_catalog_sources()) {
159 out_ << " "; 159 out_ << " ";
160 path_output_.WriteFile(out_, source); 160 path_output_.WriteFile(out_, source);
161 asset_catalog_bundles.insert(source); 161 asset_catalog_bundles.insert(source);
162 } 162 }
163 163
164 out_ << " | "; 164 out_ << " | ";
165 path_output_.WriteFile(out_, input_dep); 165 path_output_.WriteFile(out_, input_dep);
166 out_ << std::endl; 166 out_ << std::endl;
167
168 out_ << " product_type = " << target_->bundle_data().product_type()
169 << std::endl;
167 } 170 }
168 171
169 OutputFile 172 OutputFile
170 NinjaCreateBundleTargetWriter::WriteCompileAssetsCatalogInputDepsStamp( 173 NinjaCreateBundleTargetWriter::WriteCompileAssetsCatalogInputDepsStamp(
171 const std::vector<const Target*>& dependencies) { 174 const std::vector<const Target*>& dependencies) {
172 DCHECK(!dependencies.empty()); 175 DCHECK(!dependencies.empty());
173 if (dependencies.size() == 1) 176 if (dependencies.size() == 1)
174 return dependencies[0]->dependency_output_file(); 177 return dependencies[0]->dependency_output_file();
175 178
176 OutputFile xcassets_input_stamp_file = 179 OutputFile xcassets_input_stamp_file =
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 out_ << " "; 275 out_ << " ";
273 path_output_.WriteFile(out_, source); 276 path_output_.WriteFile(out_, source);
274 } 277 }
275 for (const Target* target : dependencies) { 278 for (const Target* target : dependencies) {
276 out_ << " "; 279 out_ << " ";
277 path_output_.WriteFile(out_, target->dependency_output_file()); 280 path_output_.WriteFile(out_, target->dependency_output_file());
278 } 281 }
279 out_ << std::endl; 282 out_ << std::endl;
280 return code_signing_input_stamp_file; 283 return code_signing_input_stamp_file;
281 } 284 }
OLDNEW
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_create_bundle_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698