Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: tools/gn/function_toolchain.cc

Issue 2239943002: Forward bundle product_type to the compile_xcassets tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add documentation for new substitution and regenerate reference documentation. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/ninja_create_bundle_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <limits> 6 #include <limits>
7 #include <utility> 7 #include <utility>
8 8
9 #include "tools/gn/err.h" 9 #include "tools/gn/err.h"
10 #include "tools/gn/functions.h" 10 #include "tools/gn/functions.h"
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 " The copy_bundle_data and compile_xcassets tools only allows the common\n" 851 " The copy_bundle_data and compile_xcassets tools only allows the common\n"
852 " tool substitutions. Both tools are required to create iOS/OS X bundles\n" 852 " tool substitutions. Both tools are required to create iOS/OS X bundles\n"
853 " and need only be defined on those platforms.\n" 853 " and need only be defined on those platforms.\n"
854 "\n" 854 "\n"
855 " The copy_bundle_data tool will be called with one source and needs to\n" 855 " The copy_bundle_data tool will be called with one source and needs to\n"
856 " copy (optionally optimizing the data representation) to its output. It\n" 856 " copy (optionally optimizing the data representation) to its output. It\n"
857 " may be called with a directory as input and it needs to be recursively\n" 857 " may be called with a directory as input and it needs to be recursively\n"
858 " copied.\n" 858 " copied.\n"
859 "\n" 859 "\n"
860 " The compile_xcassets tool will be called with one or more source (each\n" 860 " The compile_xcassets tool will be called with one or more source (each\n"
861 " an asset catalog) that needs to be compiled to a single output.\n" 861 " an asset catalog) that needs to be compiled to a single output. The\n"
862 " following substitutions are avaiable:\n"
863 "\n"
864 " {{inputs}}\n"
865 " Expands to the list of .xcassets to use as input to compile the\n"
866 " asset catalog.\n"
867 "\n"
868 " {{bundle_product_type}}\n"
869 " Expands to the product_type of the bundle that will contain the\n"
870 " compiled asset catalog. Usually correspond to the product_type\n"
brettw 2016/08/11 23:46:35 Grammar: "correspond" -> "corresponds"
sdefresne 2016/08/12 19:38:53 Done.
871 " property of the corresponding create_bundle target.\n"
862 "\n" 872 "\n"
863 "Separate linking and dependencies for shared libraries\n" 873 "Separate linking and dependencies for shared libraries\n"
864 "\n" 874 "\n"
865 " Shared libraries are special in that not all changes to them require\n" 875 " Shared libraries are special in that not all changes to them require\n"
866 " that dependent targets be re-linked. If the shared library is changed\n" 876 " that dependent targets be re-linked. If the shared library is changed\n"
867 " but no imports or exports are different, dependent code needn't be\n" 877 " but no imports or exports are different, dependent code needn't be\n"
868 " relinked, which can speed up the build.\n" 878 " relinked, which can speed up the build.\n"
869 "\n" 879 "\n"
870 " If your link step can output a list of exports from a shared library\n" 880 " If your link step can output a list of exports from a shared library\n"
871 " and writes the file only if the new one is different, the timestamp of\n" 881 " and writes the file only if the new one is different, the timestamp of\n"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 if (err->has_error()) 1088 if (err->has_error())
1079 return Value(); 1089 return Value();
1080 1090
1081 block_scope->DetachFromContaining(); 1091 block_scope->DetachFromContaining();
1082 scope->SetValue("toolchain_args", Value(function, std::move(block_scope)), 1092 scope->SetValue("toolchain_args", Value(function, std::move(block_scope)),
1083 function); 1093 function);
1084 return Value(); 1094 return Value();
1085 } 1095 }
1086 1096
1087 } // namespace functions 1097 } // namespace functions
OLDNEW
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/ninja_create_bundle_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698