Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2239473003: [DevTools] Removed interstatementLocation from Debugger.continueToLocation (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed interstatementLocation from Debugger.continueToLocation BUG=635947 R=dgozman@chromium.org Committed: https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a Cr-Commit-Position: refs/heads/master@{#411218}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 11 (5 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-10 21:21:05 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2239473003/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (left): https://codereview.chromium.org/2239473003/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json#oldcode534 third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:534: { "name": "interstatementLocation", "type": "boolean", "optional": true, "experimental": ...
4 years, 4 months ago (2016-08-10 23:20:37 UTC) #4
kozy
https://codereview.chromium.org/2239473003/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (left): https://codereview.chromium.org/2239473003/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json#oldcode534 third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:534: { "name": "interstatementLocation", "type": "boolean", "optional": true, "experimental": true, ...
4 years, 4 months ago (2016-08-10 23:22:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239473003/1
4 years, 4 months ago (2016-08-10 23:22:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 01:38:52 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 01:40:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a
Cr-Commit-Position: refs/heads/master@{#411218}

Powered by Google App Engine
This is Rietveld 408576698