third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js - Issue 2239473003: [DevTools] Removed interstatementLocation from Debugger.continueToLocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

Issue 2239473003: [DevTools] Removed interstatementLocation from Debugger.continueToLocation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation-expected.txt ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

diff --git a/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js b/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

index cd9a2bd56dd860ed3c7c8175593642ba8021c0f5..b6e0996878a272c95eb7528444303dc22e0b4c7f 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

+++ b/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

@@ -229,9 +229,7 @@ DebuggerScript._formatScript = function(script)

DebuggerScript.setBreakpoint = function(execState, info)

{

- var positionAlignment = info.interstatementLocation ? Debug.BreakPositionAlignment.BreakPosition : Debug.BreakPositionAlignment.Statement;

- var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, positionAlignment);

+ var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, Debug.BreakPositionAlignment.Statement);

var locations = Debug.findBreakPointActualLocations(breakId);

if (!locations.length)

return undefined;